From: Tejun Heo <tj@kernel.org>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>,
Michal Hocko <mhocko@suse.cz>, Zhouping Liu <zliu@redhat.com>,
linux-mm@kvack.org, Li Zefan <lizefan@huawei.com>,
CAI Qian <caiqian@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: memcg: cat: memory.memsw.* : Operation not supported
Date: Thu, 28 Jun 2012 11:31:45 -0700 [thread overview]
Message-ID: <20120628183145.GE22641@google.com> (raw)
In-Reply-To: <4FEBD7C0.7090906@jp.fujitsu.com>
Hello, KAME.
On Thu, Jun 28, 2012 at 01:04:16PM +0900, Kamezawa Hiroyuki wrote:
> >I still wish it's folded into CONFIG_MEMCG and conditionalized just on
> >CONFIG_SWAP tho.
> >
>
> In old days, memsw controller was not very stable. So, we devided the config.
> And, it makes size of memory for swap-device double (adds 2bytes per swapent.)
> That is the problem.
I see. Do you think it's now reasonable to drop the separate config
option? Having memcg enabled but swap unaccounted sounds half-broken
to me.
> IIRC...at that time, we made decision, cgroup has no feature to
> 'create files dynamically'. Then, we made it in static, decision was done
> at compile time and ignores "do_swap_account".
>
> Now, IIUC, we have the feature. So, it's may be a time to create the file
> with regard to "do_swap_account", making decision at boot time.
Heh, yeah, maybe I'm confused about how it happened. Anyways, let's
get it fixed.
Thanks!
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-28 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2a1a74bf-fbb5-4a6e-b958-44fff8debff2@zmail13.collab.prod.int.phx2.redhat.com>
2012-06-27 3:49 ` memcg: cat: memory.memsw.* : Operation not supported Zhouping Liu
2012-06-27 15:48 ` Michal Hocko
2012-06-27 20:04 ` David Rientjes
2012-06-27 20:09 ` Tejun Heo
2012-06-27 20:21 ` David Rientjes
2012-06-27 20:24 ` Tejun Heo
2012-06-27 20:26 ` David Rientjes
2012-06-28 4:04 ` Kamezawa Hiroyuki
2012-06-28 18:31 ` Tejun Heo [this message]
2012-06-30 3:45 ` Kamezawa Hiroyuki
2013-01-21 8:39 ` Zhouping Liu
2013-01-21 10:56 ` Michal Hocko
2013-01-21 11:12 ` Michal Hocko
2013-01-21 13:27 ` Zhouping Liu
2013-01-21 13:46 ` Michal Hocko
2012-06-29 7:16 ` Glauber Costa
2012-06-28 12:36 ` Michal Hocko
2012-06-28 18:29 ` Tejun Heo
2012-06-29 0:11 ` Kamezawa Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628183145.GE22641@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=caiqian@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=zliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).