From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx152.postini.com [74.125.245.152]) by kanga.kvack.org (Postfix) with SMTP id CEC476B005A for ; Fri, 29 Jun 2012 16:49:01 -0400 (EDT) Received: by bkcjc3 with SMTP id jc3so1404977bkc.14 for ; Fri, 29 Jun 2012 13:49:00 -0700 (PDT) Date: Fri, 29 Jun 2012 22:48:55 +0200 From: Ingo Molnar Subject: Re: [PATCH 21/40] autonuma: avoid CFS select_task_rq_fair to return -1 Message-ID: <20120629204855.GA4316@gmail.com> References: <1340888180-15355-1-git-send-email-aarcange@redhat.com> <1340888180-15355-22-git-send-email-aarcange@redhat.com> <4FEDFAB1.8050305@redhat.com> <1340996749.28750.125.camel@twins> <4FEDFD0F.7070207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FEDFD0F.7070207@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Peter Zijlstra , Andrea Arcangeli , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter , Alex Shi , Mauricio Faria de Oliveira , Konrad Rzeszutek Wilk , Don Morris , Benjamin Herrenschmidt * Rik van Riel wrote: > On 06/29/2012 03:05 PM, Peter Zijlstra wrote: > >On Fri, 2012-06-29 at 14:57 -0400, Rik van Riel wrote: > >>Either this is a scheduler bugfix, in which case you > >>are better off submitting it separately and reducing > >>the size of your autonuma patch queue, or this is a > >>behaviour change in the scheduler that needs better > >>arguments than a 1-line changelog. > > > >I've only said this like 2 or 3 times.. :/ > > I'll keep saying it until Andrea has fixed it :) But that's just wrong - patch submitters *MUST* be responsive and forthcoming. Mistakes are OK, but this goes well beyond that. A patch-queue must generally not be resubmitted for yet another review round, as long as there are yet unaddressed review feedback items. The thing is, core kernel code maintainers like PeterZ don't scale and the number of patches to review is huge - yet Andrea keeps wasting Peter's time with the same things again and again... How much is too much? Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org