From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx107.postini.com [74.125.245.107]) by kanga.kvack.org (Postfix) with SMTP id E18B86B0062 for ; Mon, 2 Jul 2012 11:51:44 -0400 (EDT) Date: Mon, 2 Jul 2012 11:42:22 -0400 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 11/40] autonuma: define the autonuma flags Message-ID: <20120702154222.GA26953@phenom.dumpdata.com> References: <1340888180-15355-1-git-send-email-aarcange@redhat.com> <1340888180-15355-12-git-send-email-aarcange@redhat.com> <20120630045825.GC3975@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120630045825.GC3975@localhost.localdomain> Sender: owner-linux-mm@kvack.org List-ID: To: Konrad Rzeszutek Wilk Cc: Andrea Arcangeli , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Peter Zijlstra , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Rik van Riel , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter , Alex Shi , Mauricio Faria de Oliveira , Don Morris , Benjamin Herrenschmidt On Sat, Jun 30, 2012 at 12:58:25AM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Jun 28, 2012 at 02:55:51PM +0200, Andrea Arcangeli wrote: > > These flags are the ones tweaked through sysfs, they control the > > behavior of autonuma, from enabling disabling it, to selecting various > > runtime options. > > > > Signed-off-by: Andrea Arcangeli > > --- > > include/linux/autonuma_flags.h | 62 ++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 62 insertions(+), 0 deletions(-) > > create mode 100644 include/linux/autonuma_flags.h > > > > diff --git a/include/linux/autonuma_flags.h b/include/linux/autonuma_flags.h > > new file mode 100644 > > index 0000000..5e29a75 > > --- /dev/null > > +++ b/include/linux/autonuma_flags.h > > @@ -0,0 +1,62 @@ > > +#ifndef _LINUX_AUTONUMA_FLAGS_H > > +#define _LINUX_AUTONUMA_FLAGS_H > > + > > +enum autonuma_flag { > > These aren't really flags. They are bit-fields. > A > > + AUTONUMA_FLAG, > > Looking at the code, this is to turn it on. Perhaps a better name such > as: AUTONUMA_ACTIVE_FLAG ? > > > > + AUTONUMA_IMPOSSIBLE_FLAG, > > + AUTONUMA_DEBUG_FLAG, > > + AUTONUMA_SCHED_LOAD_BALANCE_STRICT_FLAG, > > I might have gotten my math wrong, but if you have > AUTONUMA_SCHED_LOAD_BALACE.. set (so 3), that also means > that bit 0 and 1 are on. In other words AUTONUMA_FLAG > and AUTONUMA_IMPOSSIBLE_FLAG are turned on. > > > + AUTONUMA_SCHED_CLONE_RESET_FLAG, > > + AUTONUMA_SCHED_FORK_RESET_FLAG, > > + AUTONUMA_SCAN_PMD_FLAG, > > So this is 6, which means 110 bits. So AUTONUMA_FLAG > gets turned off. Ignore that pls. I had in my mind that test_bit was doing boolean logic (anding and masking, and such), but that is not the case. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org