Re: [PATCH v3 2/3] mm/sparse: fix possible memory leak

[Gavin Shan <shangw@linux.vnet.ibm.com>]

On Mon, Jul 02, 2012 at 02:19:39PM -0700, David Rientjes wrote:
>On Mon, 2 Jul 2012, Gavin Shan wrote:
>
>> >> diff --git a/mm/sparse.c b/mm/sparse.c
>> >> index 781fa04..a6984d9 100644
>> >> --- a/mm/sparse.c
>> >> +++ b/mm/sparse.c
>> >> @@ -75,6 +75,20 @@ static struct mem_section noinline __init_refok *sparse_index_alloc(int nid)
>> >>  	return section;
>> >>  }
>> >>  
>> >> +static inline void __meminit sparse_index_free(struct mem_section *section)
>> >> +{
>> >> +	unsigned long size = SECTIONS_PER_ROOT *
>> >> +			     sizeof(struct mem_section);
>> >> +
>> >> +	if (!section)
>> >> +		return;
>> >> +
>> >> +	if (slab_is_available())
>> >> +		kfree(section);
>> >> +	else
>> >> +		free_bootmem(virt_to_phys(section), size);
>> >
>> >Eek, does that work?
>> >
>> 
>> David, I think it's working fine. If my understanding is wrong, please
>> correct me. Thanks a lot :-)
>> 
>
>I'm thinking it should be free_bootmem(__pa(section), size);
>

Thanks for pointing it out, David.

Thanks,
Gavin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>