From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx137.postini.com [74.125.245.137]) by kanga.kvack.org (Postfix) with SMTP id 089576B0070 for ; Fri, 6 Jul 2012 01:00:25 -0400 (EDT) Received: from /spool/local by e2.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Jul 2012 01:00:25 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 831A96E804D for ; Fri, 6 Jul 2012 01:00:22 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6650Mwt389084 for ; Fri, 6 Jul 2012 01:00:22 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6650Loe002798 for ; Fri, 6 Jul 2012 02:00:22 -0300 Date: Fri, 6 Jul 2012 13:00:13 +0800 From: Gavin Shan Subject: Re: [PATCH] mm/memcg: swappiness should between 0 and 100 Message-ID: <20120706050013.GA15372@shangw> Reply-To: Gavin Shan References: <1341550312-6815-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341550312-6815-1-git-send-email-liwp.linux@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Wanpeng Li Cc: Andrew Morton , Johannes Weiner , Michal Hocko , KAMEZAWA Hiroyuki , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote: >From: Wanpeng Li > >Signed-off-by: Wanpeng Li >--- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index 5e4d1ab..69a7d45 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, It seems that we don't have the function in mainline. shangw@shangw:~/sandbox/linux/mm$ grep mem_cgroup_swappiness_write -r . shangw@shangw:~/sandbox/linux/mm$ Thanks, Gavin > struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); > struct mem_cgroup *parent; > >- if (val > 100) >+ if (val > 100 || val < 0) > return -EINVAL; > > if (cgrp->parent == NULL) >-- >1.7.5.4 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org