* [PATCH] mm/memcg: swappiness should between 0 and 100 @ 2012-07-06 4:51 Wanpeng Li 2012-07-06 5:00 ` Gavin Shan 2012-07-06 5:16 ` Gavin Shan 0 siblings, 2 replies; 6+ messages in thread From: Wanpeng Li @ 2012-07-06 4:51 UTC (permalink / raw) To: Andrew Morton Cc: Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel, Wanpeng Li From: Wanpeng Li <liwp@linux.vnet.ibm.com> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> --- mm/memcontrol.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 5e4d1ab..69a7d45 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); struct mem_cgroup *parent; - if (val > 100) + if (val > 100 || val < 0) return -EINVAL; if (cgrp->parent == NULL) -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/memcg: swappiness should between 0 and 100 2012-07-06 4:51 [PATCH] mm/memcg: swappiness should between 0 and 100 Wanpeng Li @ 2012-07-06 5:00 ` Gavin Shan 2012-07-06 5:04 ` Gavin Shan 2012-07-06 5:16 ` Gavin Shan 1 sibling, 1 reply; 6+ messages in thread From: Gavin Shan @ 2012-07-06 5:00 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote: >From: Wanpeng Li <liwp@linux.vnet.ibm.com> > >Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> >--- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index 5e4d1ab..69a7d45 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, It seems that we don't have the function in mainline. shangw@shangw:~/sandbox/linux/mm$ grep mem_cgroup_swappiness_write -r . shangw@shangw:~/sandbox/linux/mm$ Thanks, Gavin > struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); > struct mem_cgroup *parent; > >- if (val > 100) >+ if (val > 100 || val < 0) > return -EINVAL; > > if (cgrp->parent == NULL) >-- >1.7.5.4 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/memcg: swappiness should between 0 and 100 2012-07-06 5:00 ` Gavin Shan @ 2012-07-06 5:04 ` Gavin Shan 2012-07-06 5:08 ` Wanpeng Li 0 siblings, 1 reply; 6+ messages in thread From: Gavin Shan @ 2012-07-06 5:04 UTC (permalink / raw) To: Gavin Shan Cc: Wanpeng Li, Andrew Morton, Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 01:00:13PM +0800, Gavin Shan wrote: >On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote: >>From: Wanpeng Li <liwp@linux.vnet.ibm.com> >> >>Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> >>--- >> mm/memcontrol.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>index 5e4d1ab..69a7d45 100644 >>--- a/mm/memcontrol.c >>+++ b/mm/memcontrol.c >>@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, > >It seems that we don't have the function in mainline. > >shangw@shangw:~/sandbox/linux/mm$ grep mem_cgroup_swappiness_write -r . >shangw@shangw:~/sandbox/linux/mm$ > Please ignore that cause my git tree has some problems and everything in linux/mm has been cleared :-) Thanks, Gavin >Thanks, >Gavin > >> struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); >> struct mem_cgroup *parent; >> >>- if (val > 100) >>+ if (val > 100 || val < 0) >> return -EINVAL; >> >> if (cgrp->parent == NULL) >>-- >>1.7.5.4 >> >>-- >>To unsubscribe, send a message with 'unsubscribe linux-mm' in >>the body to majordomo@kvack.org. For more info on Linux MM, >>see: http://www.linux-mm.org/ . >>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >> > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/memcg: swappiness should between 0 and 100 2012-07-06 5:04 ` Gavin Shan @ 2012-07-06 5:08 ` Wanpeng Li 0 siblings, 0 replies; 6+ messages in thread From: Wanpeng Li @ 2012-07-06 5:08 UTC (permalink / raw) To: Gavin Shan Cc: Wanpeng Li, Andrew Morton, Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 01:04:30PM +0800, Gavin Shan wrote: >On Fri, Jul 06, 2012 at 01:00:13PM +0800, Gavin Shan wrote: >>On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote: >>>From: Wanpeng Li <liwp@linux.vnet.ibm.com> >>> >>>Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> >>>--- >>> mm/memcontrol.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>>diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>>index 5e4d1ab..69a7d45 100644 >>>--- a/mm/memcontrol.c >>>+++ b/mm/memcontrol.c >>>@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, >> >>It seems that we don't have the function in mainline. >> >>shangw@shangw:~/sandbox/linux/mm$ grep mem_cgroup_swappiness_write -r . >>shangw@shangw:~/sandbox/linux/mm$ >> > >Please ignore that cause my git tree has some problems and everything >in linux/mm has been cleared :-) No problem. :-) Best Regards, Wanpeng Li > >Thanks, >Gavin > >>Thanks, >>Gavin >> >>> struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); >>> struct mem_cgroup *parent; >>> >>>- if (val > 100) >>>+ if (val > 100 || val < 0) >>> return -EINVAL; >>> >>> if (cgrp->parent == NULL) >>>-- >>>1.7.5.4 >>> >>>-- >>>To unsubscribe, send a message with 'unsubscribe linux-mm' in >>>the body to majordomo@kvack.org. For more info on Linux MM, >>>see: http://www.linux-mm.org/ . >>>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >>> >> >>-- >>To unsubscribe, send a message with 'unsubscribe linux-mm' in >>the body to majordomo@kvack.org. For more info on Linux MM, >>see: http://www.linux-mm.org/ . >>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/memcg: swappiness should between 0 and 100 2012-07-06 4:51 [PATCH] mm/memcg: swappiness should between 0 and 100 Wanpeng Li 2012-07-06 5:00 ` Gavin Shan @ 2012-07-06 5:16 ` Gavin Shan 2012-07-06 5:24 ` Wanpeng Li 1 sibling, 1 reply; 6+ messages in thread From: Gavin Shan @ 2012-07-06 5:16 UTC (permalink / raw) To: Wanpeng Li Cc: Andrew Morton, Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote: >From: Wanpeng Li <liwp@linux.vnet.ibm.com> > >Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> >--- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index 5e4d1ab..69a7d45 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, > struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); > struct mem_cgroup *parent; > >- if (val > 100) >+ if (val > 100 || val < 0) Wanpeng, the "val" was defined as "u64". So how it could be less than 0? static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, u64 val) Thanks, Gavin > return -EINVAL; > > if (cgrp->parent == NULL) >-- >1.7.5.4 > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm/memcg: swappiness should between 0 and 100 2012-07-06 5:16 ` Gavin Shan @ 2012-07-06 5:24 ` Wanpeng Li 0 siblings, 0 replies; 6+ messages in thread From: Wanpeng Li @ 2012-07-06 5:24 UTC (permalink / raw) To: Gavin Shan Cc: Andrew Morton, Johannes Weiner, Michal Hocko, KAMEZAWA Hiroyuki, cgroups, linux-mm, linux-kernel On Fri, Jul 06, 2012 at 01:16:43PM +0800, Gavin Shan wrote: >On Fri, Jul 06, 2012 at 12:51:52PM +0800, Wanpeng Li wrote: >>From: Wanpeng Li <liwp@linux.vnet.ibm.com> >> >>Signed-off-by: Wanpeng Li <liwp.linux@gmail.com> >>--- >> mm/memcontrol.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>index 5e4d1ab..69a7d45 100644 >>--- a/mm/memcontrol.c >>+++ b/mm/memcontrol.c >>@@ -4176,7 +4176,7 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, >> struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp); >> struct mem_cgroup *parent; >> >>- if (val > 100) >>+ if (val > 100 || val < 0) > >Wanpeng, the "val" was defined as "u64". So how it could be less than 0? > >static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft, > u64 val) > Oh, thank you! Just ignore this patch. Regards, Wanpeng Li >Thanks, >Gavin > >> return -EINVAL; >> >> if (cgrp->parent == NULL) >>-- >>1.7.5.4 >> >>-- >>To unsubscribe, send a message with 'unsubscribe linux-mm' in >>the body to majordomo@kvack.org. For more info on Linux MM, >>see: http://www.linux-mm.org/ . >>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-06 5:24 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-06 4:51 [PATCH] mm/memcg: swappiness should between 0 and 100 Wanpeng Li 2012-07-06 5:00 ` Gavin Shan 2012-07-06 5:04 ` Gavin Shan 2012-07-06 5:08 ` Wanpeng Li 2012-07-06 5:16 ` Gavin Shan 2012-07-06 5:24 ` Wanpeng Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).