From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx159.postini.com [74.125.245.159]) by kanga.kvack.org (Postfix) with SMTP id 124BE6B0070 for ; Fri, 6 Jul 2012 01:38:04 -0400 (EDT) Received: by ghrr18 with SMTP id r18so10112416ghr.14 for ; Thu, 05 Jul 2012 22:38:03 -0700 (PDT) Date: Fri, 6 Jul 2012 13:37:31 +0800 From: Wanpeng Li Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Message-ID: <20120706053731.GD5929@kernel> Reply-To: Wanpeng Li References: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> <20120706051916.GB29829@shangw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120706051916.GB29829@shangw> Sender: owner-linux-mm@kvack.org List-ID: To: Gavin Shan Cc: Andrew Morton , Johannes Weiner , Michal Hocko , KAMEZAWA Hiroyuki , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Jul 06, 2012 at 01:19:16PM +0800, Gavin Shan wrote: >On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: >>From: Wanpeng Li >> >>Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. >> >>Signed-off-by: Wanpeng Li >>--- >> mm/memcontrol.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >>diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>index a501660..5e4d1ab 100644 >>--- a/mm/memcontrol.c >>+++ b/mm/memcontrol.c >>@@ -3976,6 +3976,8 @@ static int mem_cgroup_reset(struct cgroup *cont, unsigned int event) >> else >> res_counter_reset_failcnt(&memcg->memsw); >> break; >>+ default: >>+ BUG(); > >It might be not convinced to have "BUG()" here. You might add >something for debugging purpose. For example, > default: > printk(KERN_WARNING "%s: Unrecognized name %d\n", > __func__, name); But many funtions in mm/memcontrol.c use BUG(), if the branch is not present. Regards, Wanpeng Li > >Thanks, >Gavin > >> } >> >> return 0; >>-- >>1.7.5.4 >> >>-- >>To unsubscribe, send a message with 'unsubscribe linux-mm' in >>the body to majordomo@kvack.org. For more info on Linux MM, >>see: http://www.linux-mm.org/ . >>Don't email: email@kvack.org >> > >-- >To unsubscribe, send a message with 'unsubscribe linux-mm' in >the body to majordomo@kvack.org. For more info on Linux MM, >see: http://www.linux-mm.org/ . >Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org