From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/buddy: more comments for skip_free_areas_node()
Date: Fri, 6 Jul 2012 13:46:39 +0800 [thread overview]
Message-ID: <20120706054639.GA32570@shangw> (raw)
In-Reply-To: <CAM_iQpUQN0EEFf5G3RMiR5_51-Pfm2n1kqtQhRuTjQz-wvsmjw@mail.gmail.com>
On Fri, Jul 06, 2012 at 01:42:39PM +0800, Cong Wang wrote:
>On Fri, Jul 6, 2012 at 11:24 AM, Gavin Shan <shangw@linux.vnet.ibm.com> wrote:
>> The initial idea comes from Cong Wang. We're running out of memory
>> while calling function skip_free_areas_node(). So it would be unsafe
>> to allocate more memory from either stack or heap. The patche adds
>> more comments to address that.
>
>I think these comments should add to show_free_areas(),
>not skip_free_areas_node().
>
aha, exactly. Thanks a lot, Cong.
Thanks,
Gavin
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-06 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 3:24 [PATCH] mm/buddy: more comments for skip_free_areas_node() Gavin Shan
2012-07-06 5:42 ` Cong Wang
2012-07-06 5:46 ` Gavin Shan [this message]
2012-07-09 21:21 ` David Rientjes
2012-07-10 0:51 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706054639.GA32570@shangw \
--to=shangw@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).