From: Minchan Kim <minchan@kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Warn about costly page allocation
Date: Mon, 9 Jul 2012 23:12:26 +0900 [thread overview]
Message-ID: <20120709141225.GA17314@barrios> (raw)
In-Reply-To: <jtek81$ja5$1@dough.gmane.org>
Hi Cong,
On Mon, Jul 09, 2012 at 12:53:22PM +0000, Cong Wang wrote:
> On Mon, 09 Jul 2012 at 08:46 GMT, Minchan Kim <minchan@kernel.org> wrote:
> >>
> >> WARN_ON_ONCE would tell you what is trying to satisfy the allocation.
> >
> > Do you mean that it would be better to use WARN_ON_ONCE rather than raw printk?
> > If so, I would like to insist raw printk because WARN_ON_ONCE could be disabled
> > by !CONFIG_BUG.
> > If I miss something, could you elaborate it more?
> >
>
> Raw printk could be disabled by !CONFIG_PRINTK too, and given that:
Yes.
In such case, It is very hard to diagnose the system so at least
we enables CONFIG_PRINTK.
>
> config PRINTK
> default y
> bool "Enable support for printk" if EXPERT
>
> config BUG
> bool "BUG() support" if EXPERT
> default y
>
> they are both configurable only when ERPERT, so we don't need to
> worry much. :)
Embedded can use CONFIG_PRINTK and !CONFIG_BUG for size optimization
and printk(pr_xxx) + dump_stack is common technic used in all over kernel
sources. Do you have any reason you don't like it?
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-09 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 2:38 [PATCH] mm: Warn about costly page allocation Minchan Kim
2012-07-09 8:22 ` Mel Gorman
2012-07-09 8:46 ` Minchan Kim
2012-07-09 9:12 ` Mel Gorman
2012-07-09 12:50 ` Minchan Kim
2012-07-09 13:05 ` Mel Gorman
2012-07-09 13:19 ` Minchan Kim
2012-07-09 20:53 ` Andrew Morton
2012-07-09 12:53 ` Cong Wang
2012-07-09 14:12 ` Minchan Kim [this message]
2012-07-11 2:45 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709141225.GA17314@barrios \
--to=minchan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).