From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx117.postini.com [74.125.245.117]) by kanga.kvack.org (Postfix) with SMTP id 28C8E6B006C for ; Mon, 9 Jul 2012 18:41:02 -0400 (EDT) Date: Mon, 9 Jul 2012 15:41:00 -0700 From: Andrew Morton Subject: Re: [PATCH] mm: don't invoke __alloc_pages_direct_compact when order 0 Message-Id: <20120709154100.6a7377e6.akpm@linux-foundation.org> In-Reply-To: References: <1341588521-17744-1-git-send-email-js1304@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: JoonSoo Kim Cc: David Rientjes , Mel Gorman , Pekka Enberg , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Mon, 9 Jul 2012 23:13:50 +0900 JoonSoo Kim wrote: > >> In my kernel image, __alloc_pages_direct_compact() is not inlined by gcc. My gcc-4.4.4 doesn't inline it either. > I think __alloc_pages_direct_compact() can't be inlined by gcc, > because it is so big and is invoked two times in __alloc_pages_nodemask(). This. Large function, two callsites. Making __alloc_pages_direct_compact() __always_inline adds only 26 bytes to my page_alloc.o's .text. Such is the suckiness of passing eleven arguments! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org