From: Wanpeng Li <liwp.linux@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
William Irwin <wli@holomorphy.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/hugetlb: fix error code in hugetlbfs_alloc_inode
Date: Tue, 10 Jul 2012 10:07:21 +0800 [thread overview]
Message-ID: <20120710020721.GC2457@kernel> (raw)
In-Reply-To: <alpine.DEB.2.00.1207091901210.25143@chino.kir.corp.google.com>
On Mon, Jul 09, 2012 at 07:02:39PM -0700, David Rientjes wrote:
>On Tue, 10 Jul 2012, Wanpeng Li wrote:
>
>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
>> index c4b85d0..79a0f33 100644
>> --- a/fs/hugetlbfs/inode.c
>> +++ b/fs/hugetlbfs/inode.c
>> @@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct super_block *sb)
>> p = kmem_cache_alloc(hugetlbfs_inode_cachep, GFP_KERNEL);
>> if (unlikely(!p)) {
>> hugetlbfs_inc_free_inodes(sbinfo);
>> - return NULL;
>> + return ERR_PTR(-ENOMEM);
>> }
>> return &p->vfs_inode;
>> }
>
>So now you've removed Gavin Shan who already told you that it was correct
>as written and propose yet another bogus patch which will break. This
>isn't professional.
>
>alloc_inode() tests for a NULL return value, not for PTR_ERR(), so you
>would be introducing a bug if this patch were merged. It's completely
>correct the way it's written.
Thank you for your comments David, please ignore the patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-07-10 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 1:12 [PATCH v2] mm/hugetlb: fix error code in hugetlbfs_alloc_inode Wanpeng Li
2012-07-10 2:02 ` David Rientjes
2012-07-10 2:07 ` Wanpeng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710020721.GC2457@kernel \
--to=liwp.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).