From: Michal Hocko <mhocko@suse.cz>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] mm/memcg: calculate max hierarchy limit number instead of min
Date: Thu, 12 Jul 2012 12:18:27 +0200 [thread overview]
Message-ID: <20120712101827.GD21013@tiehlicka.suse.cz> (raw)
In-Reply-To: <20120712093211.GC3181@kernel>
On Thu 12-07-12 17:32:11, Wanpeng Li wrote:
> On Wed, Jul 11, 2012 at 03:47:57PM +0200, Michal Hocko wrote:
> >On Wed 11-07-12 21:24:41, Wanpeng Li wrote:
> >> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
> >>
> >> Since hierachical_memory_limit shows "of bytes of memory limit with
> >> regard to hierarchy under which the memory cgroup is", the count should
> >> calculate max hierarchy limit when use_hierarchy in order to show hierarchy
> >> subtree limit. hierachical_memsw_limit is the same case.
> >
> >No the patch is wrong. The hierarchical limit says when we start
> >reclaiming in the hierarchy and that one is triggered on smallest limit
> >up the way to the hierarchy root.
>
> I see function mem_cgroup_hierachy_reclaim is removal, and hierarchical
> reclaim is still work?
I am not aware of that.
> Could you explain me how it works in details, thank you for your time
> Michal.
I am not sure I understand what you are interested in.
>
> Thanks & Best Regards,
> Wanpeng Li
> >
> >What are you trying to accomplish here?
> >
> >> Signed-off-by: Wanpeng Li <liwp.linux@gmail.com>
> >> ---
> >> mm/memcontrol.c | 14 +++++++-------
> >> 1 files changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> >> index 69a7d45..6392c0a 100644
> >> --- a/mm/memcontrol.c
> >> +++ b/mm/memcontrol.c
> >> @@ -3929,10 +3929,10 @@ static void memcg_get_hierarchical_limit(struct mem_cgroup *memcg,
> >> unsigned long long *mem_limit, unsigned long long *memsw_limit)
> >> {
> >> struct cgroup *cgroup;
> >> - unsigned long long min_limit, min_memsw_limit, tmp;
> >> + unsigned long long max_limit, max_memsw_limit, tmp;
> >>
> >> - min_limit = res_counter_read_u64(&memcg->res, RES_LIMIT);
> >> - min_memsw_limit = res_counter_read_u64(&memcg->memsw, RES_LIMIT);
> >> + max_limit = res_counter_read_u64(&memcg->res, RES_LIMIT);
> >> + max_memsw_limit = res_counter_read_u64(&memcg->memsw, RES_LIMIT);
> >> cgroup = memcg->css.cgroup;
> >> if (!memcg->use_hierarchy)
> >> goto out;
> >> @@ -3943,13 +3943,13 @@ static void memcg_get_hierarchical_limit(struct mem_cgroup *memcg,
> >> if (!memcg->use_hierarchy)
> >> break;
> >> tmp = res_counter_read_u64(&memcg->res, RES_LIMIT);
> >> - min_limit = min(min_limit, tmp);
> >> + max_limit = max(max_limit, tmp);
> >> tmp = res_counter_read_u64(&memcg->memsw, RES_LIMIT);
> >> - min_memsw_limit = min(min_memsw_limit, tmp);
> >> + max_memsw_limit = max(max_memsw_limit, tmp);
> >> }
> >> out:
> >> - *mem_limit = min_limit;
> >> - *memsw_limit = min_memsw_limit;
> >> + *mem_limit = max_limit;
> >> + *memsw_limit = max_memsw_limit;
> >> }
> >>
> >> static int mem_cgroup_reset(struct cgroup *cont, unsigned int event)
> >> --
> >> 1.7.5.4
> >>
> >
> >--
> >Michal Hocko
> >SUSE Labs
> >SUSE LINUX s.r.o.
> >Lihovarska 1060/12
> >190 00 Praha 9
> >Czech Republic
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-12 10:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a>
2012-07-05 6:28 ` [PATCH] mm/memcg: replace inexistence move_lock_page_cgroup() by move_lock_mem_cgroup() in comment Wanpeng Li
2012-07-09 4:37 ` Kamezawa Hiroyuki
2012-07-11 13:24 ` [PATCH RFC] mm/memcg: calculate max hierarchy limit number instead of min Wanpeng Li
2012-07-11 13:47 ` Michal Hocko
2012-07-12 9:32 ` Wanpeng Li
2012-07-12 10:18 ` Michal Hocko [this message]
2012-07-19 6:07 ` Kamezawa Hiroyuki
2012-07-19 6:30 ` Wanpeng Li
2012-07-18 3:05 ` [PATCH] mm/memcg: wrap mem_cgroup_from_css function Wanpeng Li
2012-07-18 21:36 ` Andrew Morton
2012-07-19 1:31 ` Wanpeng Li
2012-07-19 9:14 ` Kirill A. Shutemov
2012-07-19 9:23 ` Wanpeng Li
2012-07-19 9:29 ` Kirill A. Shutemov
2012-07-19 9:38 ` Gavin Shan
2012-07-19 9:38 ` Gavin Shan
2012-07-19 9:45 ` Kirill A. Shutemov
2012-07-19 10:19 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712101827.GD21013@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwp.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).