From: Michal Hocko <mhocko@suse.cz>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org
Subject: Re: [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix
Date: Mon, 16 Jul 2012 10:06:03 +0200 [thread overview]
Message-ID: <20120716080603.GA14664@tiehlicka.suse.cz> (raw)
In-Reply-To: <alpine.LSU.2.00.1207160039120.3936@eggly.anvils>
On Mon 16-07-12 00:42:37, Hugh Dickins wrote:
> Slab poisoning gave me a General Protection Fault on the
> atomic_dec(&__task_cred(p)->user->processes);
> line of release_task() called from wait_task_zombie(),
> every time my dd to USB testing generated a memcg OOM.
Just curious, was it with the wait-on-pagereclaim patch?
> oom_kill_process() now does the put_task_struct(),
> mem_cgroup_out_of_memory() should not repeat it.
Good catch. I have missed that during review - my bad...
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
> ---
>
> mm/memcontrol.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- mmotm/mm/memcontrol.c 2012-07-11 14:50:29.808349013 -0700
> +++ linux/mm/memcontrol.c 2012-07-15 12:21:26.234289161 -0700
> @@ -1533,7 +1533,6 @@ void mem_cgroup_out_of_memory(struct mem
> points = chosen_points * 1000 / totalpages;
> oom_kill_process(chosen, gfp_mask, order, points, totalpages, memcg,
> NULL, "Memory cgroup out of memory");
> - put_task_struct(chosen);
> }
>
> static unsigned long mem_cgroup_reclaim(struct mem_cgroup *memcg,
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-16 8:06 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 1:47 [patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h David Rientjes
2012-06-26 1:47 ` [rfc][patch 2/3] mm, oom: introduce helper function to process threads during scan David Rientjes
2012-06-26 3:22 ` Kamezawa Hiroyuki
2012-06-26 6:05 ` KOSAKI Motohiro
2012-06-26 8:48 ` Michal Hocko
2012-06-26 1:47 ` [rfc][patch 3/3] mm, memcg: introduce own oom handler to iterate only over its own threads David Rientjes
2012-06-26 5:32 ` Kamezawa Hiroyuki
2012-06-26 20:38 ` David Rientjes
2012-06-27 5:35 ` David Rientjes
2012-06-28 1:43 ` David Rientjes
2012-06-28 17:16 ` Oleg Nesterov
2012-06-29 20:37 ` David Rientjes
2012-06-28 8:55 ` Kamezawa Hiroyuki
2012-06-29 20:30 ` David Rientjes
2012-07-03 17:56 ` Oleg Nesterov
2012-06-28 8:52 ` Kamezawa Hiroyuki
2012-06-26 9:58 ` Michal Hocko
2012-06-26 3:12 ` [patch 1/3] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h Kamezawa Hiroyuki
2012-06-26 6:04 ` KOSAKI Motohiro
2012-06-26 8:34 ` Michal Hocko
2012-06-29 21:06 ` [patch 1/5] " David Rientjes
2012-06-29 21:06 ` [patch 2/5] mm, oom: introduce helper function to process threads during scan David Rientjes
2012-07-12 7:18 ` Sha Zhengju
2012-06-29 21:06 ` [patch 3/5] mm, memcg: introduce own oom handler to iterate only over its own threads David Rientjes
2012-07-10 21:19 ` Andrew Morton
2012-07-10 23:24 ` David Rientjes
2012-07-12 14:50 ` Sha Zhengju
2012-06-29 21:06 ` [patch 4/5] mm, oom: reduce dependency on tasklist_lock David Rientjes
2012-07-03 18:17 ` Oleg Nesterov
2012-07-10 21:04 ` David Rientjes
2012-07-13 14:32 ` Michal Hocko
2012-07-16 7:42 ` [PATCH mmotm] mm, oom: reduce dependency on tasklist_lock: fix Hugh Dickins
2012-07-16 8:06 ` Michal Hocko [this message]
2012-07-16 9:01 ` Hugh Dickins
2012-07-16 9:27 ` Michal Hocko
2012-07-19 10:11 ` Kamezawa Hiroyuki
2012-06-29 21:07 ` [patch 5/5] mm, memcg: move all oom handling to memcontrol.c David Rientjes
2012-07-04 5:51 ` Kamezawa Hiroyuki
2012-07-13 14:34 ` Michal Hocko
2012-07-10 21:05 ` [patch 1/5] mm, oom: move declaration for mem_cgroup_out_of_memory to oom.h David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716080603.GA14664@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).