From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
aaditya.kumar.30@gmail.com, kamezawa.hiroyu@jp.fujitsu.com,
linux-mm@kvack.org
Subject: Re: + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree
Date: Wed, 18 Jul 2012 14:38:10 -0700 [thread overview]
Message-ID: <20120718143810.b15564b3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120718012200.GA27770@bbox>
On Wed, 18 Jul 2012 10:22:00 +0900
Minchan Kim <minchan@kernel.org> wrote:
> >
> > Is this really necessary? Does the zone start out all-zeroes? If not, can we
> > make it do so?
>
> Good point.
> It can remove zap_zone_vm_stats and zone->flags = 0, too.
> More important thing is that we could remove adding code to initialize
> zero whenever we add new field to zone. So I look at the code.
>
> In summary, IMHO, all is already initialie zero out but we need double
> check in mips.
>
Well, this is hardly a performance-critical path. So rather than
groveling around ensuring that each and every architectures does the
right thing, would it not be better to put a single memset() into core
MM if there is an appropriate place?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-18 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120717233115.A8E411E005C@wpzn4.hot.corp.google.com>
2012-07-18 1:22 ` + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree Minchan Kim
2012-07-18 21:38 ` Andrew Morton [this message]
2012-07-19 0:10 ` Minchan Kim
2012-07-19 0:21 ` Tejun Heo
2012-07-19 0:48 ` Minchan Kim
2012-07-19 16:57 ` Tejun Heo
2012-07-19 23:50 ` Minchan Kim
2012-07-20 17:15 ` Tejun Heo
2012-07-20 21:22 ` Andrew Morton
2012-07-20 21:36 ` Tejun Heo
2012-07-23 4:58 ` Minchan Kim
2012-07-23 15:42 ` Tejun Heo
2012-07-24 1:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718143810.b15564b3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aaditya.kumar.30@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).