From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWAHiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Gavin Shan <shangw@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memcg: wrap mem_cgroup_from_css function
Date: Thu, 19 Jul 2012 12:29:11 +0300 [thread overview]
Message-ID: <20120719092911.GA2606@shutemov.name> (raw)
In-Reply-To: <20120719092309.GA12409@kernel>
On Thu, Jul 19, 2012 at 05:23:09PM +0800, Wanpeng Li wrote:
> On Thu, Jul 19, 2012 at 12:14:20PM +0300, Kirill A. Shutemov wrote:
> >On Wed, Jul 18, 2012 at 11:05:30AM +0800, Wanpeng Li wrote:
> >> wrap mem_cgroup_from_css function to clarify get mem cgroup
> >> from cgroup_subsys_state.
> >>
> >> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
> >> Cc: Michal Hocko <mhocko@suse.cz>
> >> Cc: Johannes Weiner <hannes@cmpxchg.org>
> >> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
> >> Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com>
> >> Cc: linux-kernel@vger.kernel.org
> >> ---
> >> mm/memcontrol.c | 14 ++++++++++----
> >> 1 files changed, 10 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> >> index 58a08fc..20f6a15 100644
> >> --- a/mm/memcontrol.c
> >> +++ b/mm/memcontrol.c
> >> @@ -396,6 +396,12 @@ static void mem_cgroup_put(struct mem_cgroup *memcg);
> >> #include <net/sock.h>
> >> #include <net/ip.h>
> >>
> >> +static inline
> >> +struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *s)
> >> +{
> >> + return container_of(s, struct mem_cgroup, css);
> >> +}
> >> +
> >> static bool mem_cgroup_is_root(struct mem_cgroup *memcg);
> >> void sock_update_memcg(struct sock *sk)
> >> {
> >> @@ -820,7 +826,7 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page)
> >>
> >> struct mem_cgroup *mem_cgroup_from_cont(struct cgroup *cont)
> >> {
> >> - return container_of(cgroup_subsys_state(cont,
> >> + return mem_cgroup_from_css(cgroup_subsys_state(cont,
> >> mem_cgroup_subsys_id), struct mem_cgroup,
> >> css);
> >
> >Hm?.. Here and below too many args to mem_cgroup_from_css().
> >Have you tested the code?
>
> Hi, what's the meaning of "two many"?
>
> cgroup_subsys_state(cont, mem_cgroup_subsys_id) and
> task_subsys_state(p, mem_cgroup_subsys_id) both are
> just one arg in mem_cgroup_from_css. :-)
Em.. I guess my eyes are broken. %)
By the patch I see that mem_cgroup_from_css() here has tree arguments:
1. cgroup_subsys_state(cont, mem_cgroup_subsys_id)
2. struct mem_cgroup
3. css
Where's my parser is broken?
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-19 9:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a>
2012-07-05 6:28 ` [PATCH] mm/memcg: replace inexistence move_lock_page_cgroup() by move_lock_mem_cgroup() in comment Wanpeng Li
2012-07-09 4:37 ` Kamezawa Hiroyuki
2012-07-11 13:24 ` [PATCH RFC] mm/memcg: calculate max hierarchy limit number instead of min Wanpeng Li
2012-07-11 13:47 ` Michal Hocko
2012-07-12 9:32 ` Wanpeng Li
2012-07-12 10:18 ` Michal Hocko
2012-07-19 6:07 ` Kamezawa Hiroyuki
2012-07-19 6:30 ` Wanpeng Li
2012-07-18 3:05 ` [PATCH] mm/memcg: wrap mem_cgroup_from_css function Wanpeng Li
2012-07-18 21:36 ` Andrew Morton
2012-07-19 1:31 ` Wanpeng Li
2012-07-19 9:14 ` Kirill A. Shutemov
2012-07-19 9:23 ` Wanpeng Li
2012-07-19 9:29 ` Kirill A. Shutemov [this message]
2012-07-19 9:38 ` Gavin Shan
2012-07-19 9:45 ` Kirill A. Shutemov
2012-07-19 10:19 ` Wanpeng Li
2012-07-19 9:38 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719092911.GA2606@shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mhocko@suse.cz \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).