From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx131.postini.com [74.125.245.131]) by kanga.kvack.org (Postfix) with SMTP id 8569E6B0069 for ; Thu, 19 Jul 2012 12:57:56 -0400 (EDT) Received: by ghrr18 with SMTP id r18so3774079ghr.14 for ; Thu, 19 Jul 2012 09:57:55 -0700 (PDT) Date: Thu, 19 Jul 2012 09:57:50 -0700 From: Tejun Heo Subject: Re: + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree Message-ID: <20120719165750.GP24336@google.com> References: <20120717233115.A8E411E005C@wpzn4.hot.corp.google.com> <20120718012200.GA27770@bbox> <20120718143810.b15564b3.akpm@linux-foundation.org> <20120719001002.GA6579@bbox> <20120719002102.GN24336@google.com> <20120719004845.GA7346@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120719004845.GA7346@bbox> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , Ralf Baechle , aaditya.kumar.30@gmail.com, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, Johannes Weiner , Yinghai Lu Hello, On Thu, Jul 19, 2012 at 09:48:45AM +0900, Minchan Kim wrote: > > Maybe trigger warning if some fields which have to be zero aren't? > > It's not good because this causes adding new WARNING in that part > whenever we add new field in pgdat. It nullify this patch's goal. Maybe just do that on some fields? The goal is catching unlikely case where archs leave the struct with garbage data. I don't think full coverage is an absolute requirement. Or reorganize the fields such that fields unused by boot code is collected at the top so that it can be memset after certain offset? But, really, given how the structure is used, I think we're better off just making sure all archs clear them and maybe have a sanity check or two just in case. It's not like breakage on that front is gonna be subtle. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org