Re: + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree

[Tejun Heo <tj@kernel.org>]

Hello,

On Fri, Jul 20, 2012 at 08:50:57AM +0900, Minchan Kim wrote:
> > But, really, given how the structure is used, I think we're better off
> > just making sure all archs clear them and maybe have a sanity check or
> > two just in case.  It's not like breakage on that front is gonna be
> > subtle.
> 
> Of course, it seems all archs seems to zero-out already as I mentioned
> (Not sure, MIPS) but Andrew doesn't want it. Andrew?

So, to be more direct.  Either 1. remove the spurious initializations
(and hunt down archs which don't zero them if there's any) or 2. leave
it alone.  It's one of the data structures which are allocated and
used way before any generic code kicks in.  I mean, even how it's
deferenced is arch-dependent - it's wrapped in NODE_DATA macro for a
reason.

I would vote for #1 as it's simply brain-damaged to not zero any
global data structure and partial initialization of a data structure
already in use is silly and dangerous.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>