From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
aaditya.kumar.30@gmail.com, kamezawa.hiroyu@jp.fujitsu.com,
linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree
Date: Fri, 20 Jul 2012 14:36:41 -0700 [thread overview]
Message-ID: <20120720213641.GA6823@google.com> (raw)
In-Reply-To: <20120720142213.f4a4a68e.akpm@linux-foundation.org>
Hello, Andrew.
On Fri, Jul 20, 2012 at 02:22:13PM -0700, Andrew Morton wrote:
> My point is that having to ensure that each arch zeroes out this
> structure is difficult/costly/unreliable/fragile. It would be better
> if we can reliably clear it at some well-known place in core MM.
>
> That might mean that the memory gets cleared twice on some
> architectures, but I doubt if that matters - it's a once-off thing.
Clearing twice isn't the problem here. The problem is the risk of
zapping fields which are already in use. That would be way more
unexpected and difficult to track down than garbage value in whatever
field.
It might not be ideal but I think nudging all archs to clear all
static global structures they allocate is the better way here. It's
at least better than having to worry about this type of partial
re-initialization.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-20 21:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120717233115.A8E411E005C@wpzn4.hot.corp.google.com>
2012-07-18 1:22 ` + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree Minchan Kim
2012-07-18 21:38 ` Andrew Morton
2012-07-19 0:10 ` Minchan Kim
2012-07-19 0:21 ` Tejun Heo
2012-07-19 0:48 ` Minchan Kim
2012-07-19 16:57 ` Tejun Heo
2012-07-19 23:50 ` Minchan Kim
2012-07-20 17:15 ` Tejun Heo
2012-07-20 21:22 ` Andrew Morton
2012-07-20 21:36 ` Tejun Heo [this message]
2012-07-23 4:58 ` Minchan Kim
2012-07-23 15:42 ` Tejun Heo
2012-07-24 1:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720213641.GA6823@google.com \
--to=tj@kernel.org \
--cc=aaditya.kumar.30@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ralf@linux-mips.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).