From: Tejun Heo <tj@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
paul.gortmaker@windriver.com
Subject: Re: [RFC 1/4] hashtable: introduce a small and naive hashtable
Date: Wed, 1 Aug 2012 11:27:49 -0700 [thread overview]
Message-ID: <20120801182749.GD15477@google.com> (raw)
In-Reply-To: <50197460.8010906@gmail.com>
On Wed, Aug 01, 2012 at 08:24:32PM +0200, Sasha Levin wrote:
> On 08/01/2012 08:21 PM, Tejun Heo wrote:
> > On Wed, Aug 01, 2012 at 08:19:52PM +0200, Sasha Levin wrote:
> >> If we switch to using functions, we could no longer hide it anywhere
> >> (we'd need to either turn the buckets into a struct, or have the
> >> user pass it around to all functions).
> >
> > Create an outer struct hash_table which remembers the size?
>
> Possible. I just wanted to avoid creating new structs where they're not really required.
>
> Do you think it's worth it for eliminating those two macros?
What if someone wants to allocate hashtable dynamically which isn't
too unlikely? I think it's best to stay away from macro tricks as
much as possible although I gotta admit I fall into the macro trap
more often than I would like.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-01 18:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 18:05 [RFC 0/4] generic hashtable implementation Sasha Levin
2012-07-31 18:05 ` [RFC 1/4] hashtable: introduce a small and naive hashtable Sasha Levin
2012-07-31 18:23 ` Tejun Heo
2012-07-31 20:31 ` Sasha Levin
2012-08-01 18:19 ` Sasha Levin
2012-08-01 18:21 ` Tejun Heo
2012-08-01 18:24 ` Sasha Levin
2012-08-01 18:27 ` Tejun Heo [this message]
2012-08-01 19:06 ` Sasha Levin
2012-08-01 20:24 ` Tejun Heo
2012-08-01 22:41 ` Sasha Levin
2012-08-01 22:45 ` Tejun Heo
2012-08-02 10:00 ` Sasha Levin
2012-08-02 10:32 ` Josh Triplett
2012-08-02 11:23 ` Sasha Levin
2012-08-02 13:04 ` Sasha Levin
2012-08-02 16:15 ` Josh Triplett
2012-08-02 16:48 ` Sasha Levin
2012-08-02 17:44 ` Josh Triplett
2012-08-02 17:54 ` Sasha Levin
2012-08-02 20:41 ` Josh Triplett
2012-08-02 21:47 ` Sasha Levin
2012-08-03 17:59 ` Josh Triplett
2012-08-02 16:03 ` Eric W. Biederman
2012-08-02 16:34 ` Sasha Levin
2012-08-02 16:40 ` Eric W. Biederman
2012-08-02 17:32 ` Linus Torvalds
2012-08-02 17:48 ` Eric Dumazet
2012-08-02 17:59 ` Josh Triplett
2012-08-02 18:08 ` Linus Torvalds
2012-08-02 20:25 ` Josh Triplett
2012-08-02 20:32 ` Linus Torvalds
2012-08-02 21:21 ` Josh Triplett
2012-08-02 21:50 ` Linus Torvalds
2012-08-02 9:35 ` Josh Triplett
2012-07-31 18:05 ` [RFC 2/4] user_ns: use new hashtable implementation Sasha Levin
2012-07-31 18:05 ` [RFC 3/4] mm,ksm: " Sasha Levin
2012-07-31 18:05 ` [RFC 4/4] workqueue: " Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801182749.GD15477@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paul.gortmaker@windriver.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).