From: Christoph Lameter <cl@linux.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Joonsoo Kim <js1304@gmail.com>
Subject: Common10 [01/20] slub: Add debugging to verify correct cache use on kmem_cache_free()
Date: Fri, 03 Aug 2012 14:20:53 -0500 [thread overview]
Message-ID: <20120803192148.274651124@linux.com> (raw)
In-Reply-To: 20120803192052.448575403@linux.com
[-- Attachment #1: slub_new_debug --]
[-- Type: text/plain, Size: 1094 bytes --]
Add additional debugging to check that the objects is actually from the cache
the caller claims. Doing so currently trips up some other debugging code. It
takes a lot to infer from that what was happening.
V2: Only warn once.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2012-08-03 14:16:27.396663869 -0500
+++ linux-2.6/mm/slub.c 2012-08-03 14:16:38.664866880 -0500
@@ -2607,6 +2607,13 @@ void kmem_cache_free(struct kmem_cache *
page = virt_to_head_page(x);
+ if (kmem_cache_debug(s) && page->slab != s) {
+ printk("kmem_cache_free: Wrong slab cache. %s but object"
+ " is from %s\n", page->slab->name, s->name);
+ WARN_ON_ONCE(1);
+ return;
+ }
+
slab_free(s, page, x, _RET_IP_);
trace_kmem_cache_free(_RET_IP_, x);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-03 19:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 19:20 Common10 [00/20] Sl[auo]b: Common code rework V10 Christoph Lameter
2012-08-03 19:20 ` Christoph Lameter [this message]
2012-08-03 19:20 ` Common10 [02/20] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-08-03 19:20 ` Common10 [03/20] Rename oops label Christoph Lameter
2012-08-03 19:20 ` Common10 [04/20] Improve error handling in kmem_cache_create Christoph Lameter
2012-08-03 19:20 ` Common10 [05/20] Move list_add() to slab_common.c Christoph Lameter
2012-08-04 17:01 ` JoonSoo Kim
2012-08-08 14:47 ` Christoph Lameter (Open Source)
2012-08-03 19:20 ` Common10 [06/20] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-08-04 17:21 ` JoonSoo Kim
2012-08-08 14:51 ` Christoph Lameter (Open Source)
2012-08-03 19:20 ` Common10 [07/20] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-03 19:21 ` Common10 [08/20] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-08-03 19:21 ` Common10 [09/20] Get rid of __kmem_cache_destroy Christoph Lameter
2012-08-03 19:21 ` Common10 [10/20] Move duping of slab name to slab_common.c Christoph Lameter
2012-08-04 17:34 ` JoonSoo Kim
2012-08-08 14:59 ` Christoph Lameter (Open Source)
2012-08-14 18:42 ` JoonSoo Kim
2012-08-03 19:21 ` Common10 [11/20] Do slab aliasing call from common code Christoph Lameter
2012-08-04 17:44 ` JoonSoo Kim
2012-08-08 15:40 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [12/20] Move sysfs_slab_add to common Christoph Lameter
2012-08-04 17:46 ` JoonSoo Kim
2012-08-08 15:51 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [13/20] Move kmem_cache allocations into common code Christoph Lameter
2012-08-04 17:48 ` JoonSoo Kim
2012-08-08 17:31 ` Christoph Lameter (Open Source)
2012-08-08 13:51 ` Glauber Costa
2012-08-08 17:56 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [14/20] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-08-08 13:15 ` Glauber Costa
2012-08-08 17:45 ` Christoph Lameter (Open Source)
2012-08-03 19:21 ` Common10 [15/20] Move kmem_cache refcounting to common code Christoph Lameter
2012-08-03 19:21 ` Common10 [16/20] slub: Use a statically allocated kmem_cache boot structure for bootstrap Christoph Lameter
2012-08-04 17:50 ` JoonSoo Kim
2012-08-03 19:21 ` Common10 [17/20] slab: Simplify bootstrap Christoph Lameter
2012-08-03 19:21 ` Common10 [18/20] create common functions for boot slab creation Christoph Lameter
2012-08-03 19:21 ` Common10 [19/20] slab: Use the new create_boot_cache function to simplify bootstrap Christoph Lameter
2012-08-03 19:21 ` Common10 [20/20] Common alignment code Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803192148.274651124@linux.com \
--to=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).