From: Minchan Kim <minchan@kernel.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Nitin Gupta <ngupta@vflare.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
linux-mm@kvack.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] zsmalloc: s/firstpage/page in new copy map funcs
Date: Wed, 8 Aug 2012 13:57:12 +0900 [thread overview]
Message-ID: <20120808045712.GE4247@bbox> (raw)
In-Reply-To: <1342630556-28686-1-git-send-email-sjenning@linux.vnet.ibm.com>
Hi Greg,
When do you merge this series?
Thanks.
On Wed, Jul 18, 2012 at 11:55:54AM -0500, Seth Jennings wrote:
> firstpage already has precedent and meaning the first page
> of a zspage. In the case of the copy mapping functions,
> it is the first of a pair of pages needing to be mapped.
>
> This patch just renames the firstpage argument to "page" to
> avoid confusion.
>
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> ---
> drivers/staging/zsmalloc/zsmalloc-main.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/zsmalloc/zsmalloc-main.c b/drivers/staging/zsmalloc/zsmalloc-main.c
> index 8b0bcb6..3c83c65 100644
> --- a/drivers/staging/zsmalloc/zsmalloc-main.c
> +++ b/drivers/staging/zsmalloc/zsmalloc-main.c
> @@ -470,15 +470,15 @@ static struct page *find_get_zspage(struct size_class *class)
> return page;
> }
>
> -static void zs_copy_map_object(char *buf, struct page *firstpage,
> +static void zs_copy_map_object(char *buf, struct page *page,
> int off, int size)
> {
> struct page *pages[2];
> int sizes[2];
> void *addr;
>
> - pages[0] = firstpage;
> - pages[1] = get_next_page(firstpage);
> + pages[0] = page;
> + pages[1] = get_next_page(page);
> BUG_ON(!pages[1]);
>
> sizes[0] = PAGE_SIZE - off;
> @@ -493,15 +493,15 @@ static void zs_copy_map_object(char *buf, struct page *firstpage,
> kunmap_atomic(addr);
> }
>
> -static void zs_copy_unmap_object(char *buf, struct page *firstpage,
> +static void zs_copy_unmap_object(char *buf, struct page *page,
> int off, int size)
> {
> struct page *pages[2];
> int sizes[2];
> void *addr;
>
> - pages[0] = firstpage;
> - pages[1] = get_next_page(firstpage);
> + pages[0] = page;
> + pages[1] = get_next_page(page);
> BUG_ON(!pages[1]);
>
> sizes[0] = PAGE_SIZE - off;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-08-08 4:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 16:55 [PATCH 1/3] zsmalloc: s/firstpage/page in new copy map funcs Seth Jennings
2012-07-18 16:55 ` [PATCH 2/3] zsmalloc: prevent mappping in interrupt context Seth Jennings
2012-07-23 0:13 ` Minchan Kim
2012-07-18 16:55 ` [PATCH 3/3] zsmalloc: add page table mapping method Seth Jennings
2012-07-23 0:26 ` Minchan Kim
2012-07-23 0:33 ` Seth Jennings
2012-07-23 0:46 ` Minchan Kim
2012-07-23 2:15 ` Nitin Gupta
2012-07-23 0:11 ` [PATCH 1/3] zsmalloc: s/firstpage/page in new copy map funcs Minchan Kim
2012-07-23 22:10 ` Seth Jennings
2012-07-23 22:27 ` Greg Kroah-Hartman
2012-07-24 2:24 ` Minchan Kim
2012-07-24 14:54 ` Greg Kroah-Hartman
2012-08-08 4:57 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808045712.GE4247@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).