linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Glauber Costa <glommer@parallels.com>,
	David Rientjes <rientjes@google.com>,
	Pekka Enberg <penberg@kernel.org>,
	linux-mm@kvack.org
Subject: Common11 [02/20] slub: Use kmem_cache for the kmem_cache structure
Date: Wed, 08 Aug 2012 16:01:31 -0500	[thread overview]
Message-ID: <20120808210209.416831074@linux.com> (raw)
In-Reply-To: 20120808210129.987345284@linux.com

[-- Attachment #1: slub_use_kmem_cache --]
[-- Type: text/plain, Size: 1516 bytes --]

Do not use kmalloc() but kmem_cache_alloc() for the allocation
of the kmem_cache structures in slub.

Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Christoph Lameter <cl@linux.com>

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2012-08-03 09:01:06.650720492 -0500
+++ linux-2.6/mm/slub.c	2012-08-03 09:01:23.583012476 -0500
@@ -213,7 +213,7 @@ static inline int sysfs_slab_alias(struc
 static inline void sysfs_slab_remove(struct kmem_cache *s)
 {
 	kfree(s->name);
-	kfree(s);
+	kmem_cache_free(kmem_cache, s);
 }
 
 #endif
@@ -3962,7 +3962,7 @@ struct kmem_cache *__kmem_cache_create(c
 	if (!n)
 		return NULL;
 
-	s = kmalloc(kmem_size, GFP_KERNEL);
+	s = kmem_cache_alloc(kmem_cache, GFP_KERNEL);
 	if (s) {
 		if (kmem_cache_open(s, n,
 				size, align, flags, ctor)) {
@@ -3979,7 +3979,7 @@ struct kmem_cache *__kmem_cache_create(c
 			list_del(&s->list);
 			kmem_cache_close(s);
 		}
-		kfree(s);
+		kmem_cache_free(kmem_cache, s);
 	}
 	kfree(n);
 	return NULL;
@@ -5217,7 +5217,7 @@ static void kmem_cache_release(struct ko
 	struct kmem_cache *s = to_slab(kobj);
 
 	kfree(s->name);
-	kfree(s);
+	kmem_cache_free(kmem_cache, s);
 }
 
 static const struct sysfs_ops slab_sysfs_ops = {

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-08-08 21:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08 21:01 Common11 [00/20] Sl[auo]b: Common code rework V11 Christoph Lameter
2012-08-08 21:01 ` Common11 [01/20] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-08-08 21:01 ` Christoph Lameter [this message]
2012-08-08 21:01 ` Common11 [03/20] Rename oops label Christoph Lameter
2012-08-08 21:01 ` Common11 [04/20] Improve error handling in kmem_cache_create Christoph Lameter
2012-08-08 21:01 ` Common11 [05/20] Move list_add() to slab_common.c Christoph Lameter
2012-08-08 21:01 ` Common11 [06/20] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-08-09  9:59   ` Glauber Costa
2012-08-09 13:56     ` Christoph Lameter (Open Source)
2012-08-08 21:01 ` Common11 [07/20] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-08 21:01 ` Common11 [08/20] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-08-08 21:01 ` Common11 [09/20] Get rid of __kmem_cache_destroy Christoph Lameter
2012-08-08 21:01 ` Common11 [10/20] Move duping of slab name to slab_common.c Christoph Lameter
2012-08-08 21:01 ` Common11 [11/20] Do slab aliasing call from common code Christoph Lameter
2012-08-08 21:01 ` Common11 [12/20] Move sysfs_slab_add to common Christoph Lameter
2012-08-08 21:01 ` Common11 [13/20] Move kmem_cache allocations into common code Christoph Lameter
2012-08-08 21:01 ` Common11 [14/20] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-08-08 21:01 ` Common11 [15/20] Move kmem_cache refcounting to common code Christoph Lameter
2012-08-08 21:01 ` Common11 [16/20] slab: Simplify bootstrap Christoph Lameter
2012-08-08 21:01 ` Common11 [17/20] create common functions for boot slab creation Christoph Lameter
2012-08-08 21:01 ` Common11 [18/20] slub: Use a statically allocated kmem_cache boot structure for bootstrap Christoph Lameter
2012-08-08 21:01 ` Common11 [19/20] slab: Use the new create_boot_cache function to simplify bootstrap Christoph Lameter
2012-08-08 21:01 ` Common11 [20/20] Common alignment code Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120808210209.416831074@linux.com \
    --to=cl@linux.com \
    --cc=glommer@parallels.com \
    --cc=js1304@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).