From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx196.postini.com [74.125.245.196]) by kanga.kvack.org (Postfix) with SMTP id A8C7A6B0088 for ; Mon, 13 Aug 2012 07:19:08 -0400 (EDT) Date: Mon, 13 Aug 2012 14:19:27 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 01/12] thp: fix the count of THP_COLLAPSE_ALLOC Message-ID: <20120813111927.GA8985@shutemov.name> References: <5028E12C.70101@linux.vnet.ibm.com> <5028E14C.7060905@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5028E14C.7060905@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Xiao Guangrong Cc: Andrew Morton , Andrea Arcangeli , Hugh Dickins , David Rientjes , LKML , Linux Memory Management List On Mon, Aug 13, 2012 at 07:13:16PM +0800, Xiao Guangrong wrote: > THP_COLLAPSE_ALLOC is double counted if NUMA is disabled since it has > already been calculated in khugepaged_alloc_hugepage > > Signed-off-by: Xiao Guangrong Acked-by: Kirill A. Shutemov > --- > mm/huge_memory.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 57c4b93..80bcd42 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1880,9 +1880,9 @@ static void collapse_huge_page(struct mm_struct *mm, > *hpage = ERR_PTR(-ENOMEM); > return; > } > + count_vm_event(THP_COLLAPSE_ALLOC); > #endif > > - count_vm_event(THP_COLLAPSE_ALLOC); > if (unlikely(mem_cgroup_newpage_charge(new_page, mm, GFP_KERNEL))) { > #ifdef CONFIG_NUMA > put_page(new_page); > -- > 1.7.7.6 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org