From: Will Deacon <will.deacon@arm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hillf Danton <dhillf@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: hugetlb: flush dcache before returning zeroed huge page to userspace
Date: Thu, 16 Aug 2012 19:19:31 +0100 [thread overview]
Message-ID: <20120816181931.GA19401@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20120816180614.GB12578@dhcp22.suse.cz>
On Thu, Aug 16, 2012 at 07:06:14PM +0100, Michal Hocko wrote:
> On Thu 16-08-12 18:34:59, Will Deacon wrote:
> > I just did it that way to match the flag clearing for normal pages. I can
> > move it into dequeue if you think it's worthwhile but in the worst case it
> > just adds a clear_bit call, so I doubt it's measurable.
>
> I do not have a strong opinion on that but the flags come in cleared when
> they are freshly allocated (gather_surplus_pages) so then it would be
> more appropriate in free_huge_page when enqueue_huge_page is called.
Makes sense, I'll move the call into free_huge_page.
Cheers,
Will
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-16 18:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 14:32 [PATCH] mm: hugetlb: flush dcache before returning zeroed huge page to userspace Will Deacon
2012-07-05 12:37 ` Hillf Danton
2012-07-05 14:17 ` Will Deacon
2012-07-06 13:15 ` Hillf Danton
2012-07-09 12:25 ` Michal Hocko
2012-07-09 14:13 ` Will Deacon
2012-07-09 23:57 ` Hugh Dickins
2012-07-10 9:45 ` Will Deacon
2012-07-10 10:42 ` Will Deacon
2012-07-11 17:48 ` Will Deacon
2012-07-12 11:16 ` Michal Hocko
2012-07-12 11:26 ` James Bottomley
2012-07-12 11:26 ` Will Deacon
2012-07-12 11:57 ` Michal Hocko
2012-08-07 16:03 ` Will Deacon
2012-08-08 16:26 ` Michal Hocko
2012-08-16 16:09 ` Will Deacon
2012-08-16 17:25 ` Michal Hocko
2012-08-16 17:34 ` Will Deacon
2012-08-16 18:06 ` Michal Hocko
2012-08-16 18:19 ` Will Deacon [this message]
2012-08-16 18:20 ` Michal Hocko
2012-08-16 18:32 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816181931.GA19401@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).