From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx207.postini.com [74.125.245.207]) by kanga.kvack.org (Postfix) with SMTP id 69CE66B0044 for ; Wed, 22 Aug 2012 18:46:09 -0400 (EDT) Date: Thu, 23 Aug 2012 00:46:03 +0200 From: Andrea Arcangeli Subject: Re: [PATCH 19/36] autonuma: memory follows CPU algorithm and task/mm_autonuma stats collection Message-ID: <20120822224603.GH8107@redhat.com> References: <1345647560-30387-1-git-send-email-aarcange@redhat.com> <1345647560-30387-20-git-send-email-aarcange@redhat.com> <20120822212459.GC8107@redhat.com> <20120822223733.GQ16230@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120822223733.GQ16230@one.firstfloor.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Hi Andi, On Thu, Aug 23, 2012 at 12:37:33AM +0200, Andi Kleen wrote: > > > > This comment seems quite accurate to me (btw I taken it from > > sched-numa rewrite with minor changes). > > I had expected it to describe the next function. If it's a strategic > overview maybe it should be somewhere else. Well the next function is last_nid_set, and that's where the last_nid logic is implemented. The comment explains why last_nid statistically provides a benefit so I thought it was an ok location, but I welcome suggestions to move it somewhere else. Thanks, Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org