From: Rafael Aquini <aquini@redhat.com>
To: Rik van Riel <riel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Rusty Russell <rusty@rustcorp.com.au>, Mel Gorman <mel@csn.ul.ie>,
Andi Kleen <andi@firstfloor.org>,
Andrew Morton <akpm@linux-foundation.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH v8 1/5] mm: introduce a common interface for balloon pages mobility
Date: Thu, 23 Aug 2012 13:06:48 -0300 [thread overview]
Message-ID: <20120823160647.GA10777@t510.redhat.com> (raw)
In-Reply-To: <50365443.1070104@redhat.com>
On Thu, Aug 23, 2012 at 12:03:15PM -0400, Rik van Riel wrote:
> >
> >Not "longer" - apparently forever unless user resend the leak command.
> >It's wrong - it should
> >1. not tell host if nothing was done
> >2. after migration finished leak and tell host
>
> Agreed. If the balloon is told to leak N pages, and could
> not do so because those pages were locked, the balloon driver
> needs to retry (maybe waiting on a page lock?) and not signal
> completion until after the job has been completed.
>
> Having the balloon driver wait on the page lock should be
> fine, because compaction does not hold the page lock for
> long.
And that is precisely what leak_balloon is doing. When it stumbles across a
locked page it gets rid of that leak round to give a shot for compaction to
finish its task.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-23 16:07 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 12:47 [PATCH v8 0/5] make balloon pages movable by compaction Rafael Aquini
2012-08-21 12:47 ` [PATCH v8 1/5] mm: introduce a common interface for balloon pages mobility Rafael Aquini
2012-08-21 13:52 ` Michael S. Tsirkin
2012-08-21 14:25 ` Michael S. Tsirkin
2012-08-21 15:16 ` Peter Zijlstra
2012-08-21 15:41 ` Michael S. Tsirkin
2012-08-21 17:42 ` Rafael Aquini
2012-08-21 19:28 ` Michael S. Tsirkin
2012-08-21 17:55 ` Rafael Aquini
2012-08-21 19:16 ` Michael S. Tsirkin
2012-08-21 19:34 ` Rafael Aquini
2012-08-22 0:06 ` Michael S. Tsirkin
2012-08-21 15:20 ` Peter Zijlstra
2012-08-21 16:24 ` Paul E. McKenney
2012-08-21 17:28 ` Rafael Aquini
2012-08-21 19:13 ` Michael S. Tsirkin
2012-08-21 19:23 ` Rafael Aquini
2012-08-21 19:30 ` Michael S. Tsirkin
2012-08-21 20:45 ` Rafael Aquini
2012-08-22 0:07 ` Michael S. Tsirkin
2012-08-22 1:19 ` Rafael Aquini
2012-08-22 9:33 ` Michael S. Tsirkin
2012-08-23 2:19 ` Rafael Aquini
2012-08-23 10:01 ` Michael S. Tsirkin
2012-08-23 12:13 ` Rafael Aquini
2012-08-23 12:34 ` Michael S. Tsirkin
2012-08-23 13:06 ` Rafael Aquini
2012-08-23 13:53 ` Michael S. Tsirkin
2012-08-23 15:21 ` Rafael Aquini
2012-08-23 15:54 ` Michael S. Tsirkin
2012-08-23 16:03 ` Rik van Riel
2012-08-23 16:06 ` Rafael Aquini [this message]
2012-08-23 16:10 ` Michael S. Tsirkin
2012-08-23 16:25 ` Michael S. Tsirkin
2012-08-23 17:28 ` Rafael Aquini
2012-08-23 17:59 ` Rik van Riel
2012-08-23 23:36 ` Michael S. Tsirkin
2012-08-24 0:26 ` Rafael Aquini
2012-08-24 0:33 ` Rafael Aquini
2012-08-24 0:38 ` Rafael Aquini
2012-08-24 0:49 ` Rafael Aquini
2012-08-24 3:12 ` Rik van Riel
2012-08-24 8:03 ` Michael S. Tsirkin
2012-08-21 12:47 ` [PATCH v8 2/5] mm: introduce compaction and migration for ballooned pages Rafael Aquini
2012-08-21 12:47 ` [PATCH v8 3/5] virtio_balloon: introduce migration primitives to balloon pages Rafael Aquini
2012-08-21 14:40 ` Michael S. Tsirkin
2012-08-21 15:34 ` Peter Zijlstra
2012-08-21 15:37 ` Peter Zijlstra
2012-08-21 14:57 ` Michael S. Tsirkin
2012-08-21 12:47 ` [PATCH v8 4/5] mm: introduce putback_movable_pages() Rafael Aquini
2012-08-21 14:42 ` Michael S. Tsirkin
2012-08-21 12:47 ` [PATCH v8 5/5] mm: add vm event counters for balloon pages compaction Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120823160647.GA10777@t510.redhat.com \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan@kernel.org \
--cc=mst@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).