linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan@kernel.org>
Cc: Kyungmin Park <kmpark@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2/2] mm: support MIGRATE_DISCARD
Date: Fri, 7 Sep 2012 09:10:29 +0100	[thread overview]
Message-ID: <20120907081029.GU11266@suse.de> (raw)
In-Reply-To: <20120907022601.GH16231@bbox>

On Fri, Sep 07, 2012 at 11:26:01AM +0900, Minchan Kim wrote:
> On Fri, Sep 07, 2012 at 09:57:12AM +0900, Kyungmin Park wrote:
> > Hi Mel,
> > 
> > After apply your patch, It got the below message.
> > Please note that it's not the latest kernel. it's kernel v3.0.31 + CMA
> > + your patch.
> > It seems it should not be active but it contains active field.
> 
> Yeb. At the moment, shrink_page_list shouldn't handle active pages
> so we should clear PG_active bit in reclaim_clean_pages_from_list.
> 

Yep, that was an obvious thing I missed. It was a very fast prototype to
illustrate my point. It should be possible to fix.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-09-07  8:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05  8:11 [PATCH 1/2] mm: change enum migrate_mode with bitwise type Minchan Kim
2012-09-05  8:11 ` [PATCH 2/2] mm: support MIGRATE_DISCARD Minchan Kim
2012-09-05 10:56   ` Mel Gorman
2012-09-06  5:31     ` Minchan Kim
2012-09-06  8:29       ` Mel Gorman
2012-09-06  9:03         ` Mel Gorman
2012-09-07  0:57           ` Kyungmin Park
2012-09-07  2:26             ` Minchan Kim
2012-09-07  8:10               ` Mel Gorman [this message]
2012-09-07  2:24           ` Minchan Kim
2012-09-07  5:57             ` Kyungmin Park
2012-09-07  7:31               ` Kyungmin Park
2012-09-07  8:17                 ` Minchan Kim
2012-09-07  8:57                   ` Kyungmin Park
2012-09-07  8:21             ` Mel Gorman
2012-09-07  9:32               ` Mel Gorman
2012-09-08  0:16                 ` Minchan Kim
2012-09-05 12:43   ` Michal Nazarewicz
2012-12-21 13:04   ` lihanhui
2012-09-05 12:41 ` [PATCH 1/2] mm: change enum migrate_mode with bitwise type Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120907081029.GU11266@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=kmpark@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mina86@mina86.com \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).