From: Minchan Kim <minchan@kernel.org>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2/2] mm: support MIGRATE_DISCARD
Date: Fri, 7 Sep 2012 17:17:18 +0900 [thread overview]
Message-ID: <20120907081718.GA31784@bbox> (raw)
In-Reply-To: <CAH9JG2XozEBOah1BsaowbU=j3SE35wZVXkDjZhK7GLUzcTbfEA@mail.gmail.com>
Hi Kyungmin,
On Fri, Sep 07, 2012 at 04:31:17PM +0900, Kyungmin Park wrote:
> On 9/7/12, Kyungmin Park <kmpark@infradead.org> wrote:
> > Hi Minchan,
> >
> > I tested Mel patch again with ClearPageActive(page). but after some
> > testing, it's stall and can't return from
> > reclaim_clean_pages_from_list(&cc.migratepages).
> >
> > Maybe it's related with unmap feature from yours?
> > stall is not happened from your codes until now.
> >
> > I'll test it more and report any issue if happened.
> Updated. it's hang also. there are other issues.
It was silly mistake in my patch and I suspect it fixes your issue
because I guess you already tried below patch when you compiled and saw
warning message.
Anyway, if you see hang still after applying below patch,
please enable CONFIG_DEBUG_VM and retest, if you find something, report it.
I hope CONFIG_DEBUG_VM catch something.
Thanks.
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6668115..51d3f66 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5705,7 +5705,7 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned
break;
}
- reclaim_clean_pages_from_list(&cc.migratepages, cc.zone);
+ reclaim_clean_pages_from_list(cc.zone, &cc.migratepages);
ret = migrate_pages(&cc.migratepages,
__alloc_contig_migrate_alloc,
(END)
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-07 8:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 8:11 [PATCH 1/2] mm: change enum migrate_mode with bitwise type Minchan Kim
2012-09-05 8:11 ` [PATCH 2/2] mm: support MIGRATE_DISCARD Minchan Kim
2012-09-05 10:56 ` Mel Gorman
2012-09-06 5:31 ` Minchan Kim
2012-09-06 8:29 ` Mel Gorman
2012-09-06 9:03 ` Mel Gorman
2012-09-07 0:57 ` Kyungmin Park
2012-09-07 2:26 ` Minchan Kim
2012-09-07 8:10 ` Mel Gorman
2012-09-07 2:24 ` Minchan Kim
2012-09-07 5:57 ` Kyungmin Park
2012-09-07 7:31 ` Kyungmin Park
2012-09-07 8:17 ` Minchan Kim [this message]
2012-09-07 8:57 ` Kyungmin Park
2012-09-07 8:21 ` Mel Gorman
2012-09-07 9:32 ` Mel Gorman
2012-09-08 0:16 ` Minchan Kim
2012-09-05 12:43 ` Michal Nazarewicz
2012-12-21 13:04 ` lihanhui
2012-09-05 12:41 ` [PATCH 1/2] mm: change enum migrate_mode with bitwise type Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907081718.GA31784@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).