From: Mel Gorman <mgorman@suse.de>
To: Shaohua Li <shli@kernel.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, aarcange@redhat.com
Subject: Re: [patch 1/2 v2]compaction: abort compaction loop if lock is contended or run too long
Date: Mon, 10 Sep 2012 09:11:56 +0100 [thread overview]
Message-ID: <20120910081156.GD11266@suse.de> (raw)
In-Reply-To: <20120910011830.GC3715@kernel.org>
On Mon, Sep 10, 2012 at 09:18:30AM +0800, Shaohua Li wrote:
> isolate_migratepages_range() might isolate none pages, for example, when
> zone->lru_lock is contended and compaction is async. In this case, we should
> abort compaction, otherwise, compact_zone will run a useless loop and make
> zone->lru_lock is even contended.
>
> V2:
> only abort the compaction if lock is contended or run too long
> Rearranged the code by Andrea Arcangeli.
>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-10 8:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 1:18 [patch 1/2 v2]compaction: abort compaction loop if lock is contended or run too long Shaohua Li
2012-09-10 8:11 ` Mel Gorman [this message]
2012-09-11 1:45 ` Minchan Kim
2012-09-11 8:29 ` Shaohua Li
2012-09-11 8:40 ` Minchan Kim
2012-09-11 23:34 ` Andrew Morton
2012-09-12 0:48 ` Andrea Arcangeli
2012-09-12 21:20 ` Andrew Morton
2012-09-12 23:48 ` Andrea Arcangeli
2012-09-13 0:47 ` Minchan Kim
2012-09-13 2:49 ` Shaohua Li
2012-09-13 9:38 ` Mel Gorman
2012-09-13 10:13 ` Shaohua Li
2012-09-13 16:04 ` Andrea Arcangeli
2012-09-13 16:31 ` Mel Gorman
2012-09-13 17:11 ` Andrea Arcangeli
2012-09-13 10:03 ` Mel Gorman
2012-09-12 11:08 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910081156.GD11266@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).