* [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined [not found] <20120910111638.GC9660@localhost> @ 2012-09-10 12:57 ` Fengguang Wu 2012-09-10 12:58 ` Glauber Costa 0 siblings, 1 reply; 4+ messages in thread From: Fengguang Wu @ 2012-09-10 12:57 UTC (permalink / raw) To: Glauber Costa; +Cc: kernel-janitors, Linux Memory Management List Glauber, The patch entitled sl[au]b: Allocate objects from memcg cache changes include/linux/slub_def.h | 15 ++++++++++----- which triggers this warning: drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined It's the MAX_LEVEL that is defined in include/linux/idr.h. MAX_LEVEL is obviously too generic. Better adding some prefix to it? Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined 2012-09-10 12:57 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined Fengguang Wu @ 2012-09-10 12:58 ` Glauber Costa 2012-09-10 13:06 ` Fengguang Wu 0 siblings, 1 reply; 4+ messages in thread From: Glauber Costa @ 2012-09-10 12:58 UTC (permalink / raw) To: Fengguang Wu; +Cc: kernel-janitors, Linux Memory Management List On 09/10/2012 04:57 PM, Fengguang Wu wrote: > Glauber, > > The patch entitled > > sl[au]b: Allocate objects from memcg cache > > changes > > include/linux/slub_def.h | 15 ++++++++++----- > > which triggers this warning: > > drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined > > It's the MAX_LEVEL that is defined in include/linux/idr.h. > > MAX_LEVEL is obviously too generic. Better adding some prefix to it? > I don't see any MAX_LEVEL definition in this patch. You say it is defined in include/linux/idr.h, and as the diffstat shows, I am not touching this file. I think this needs patching independently. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined 2012-09-10 12:58 ` Glauber Costa @ 2012-09-10 13:06 ` Fengguang Wu 2012-09-10 14:02 ` Glauber Costa 0 siblings, 1 reply; 4+ messages in thread From: Fengguang Wu @ 2012-09-10 13:06 UTC (permalink / raw) To: Glauber Costa; +Cc: kernel-janitors, Linux Memory Management List On Mon, Sep 10, 2012 at 04:58:02PM +0400, Glauber Costa wrote: > On 09/10/2012 04:57 PM, Fengguang Wu wrote: > > Glauber, > > > > The patch entitled > > > > sl[au]b: Allocate objects from memcg cache > > > > changes > > > > include/linux/slub_def.h | 15 ++++++++++----- > > > > which triggers this warning: > > > > drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined > > > > It's the MAX_LEVEL that is defined in include/linux/idr.h. > > > > MAX_LEVEL is obviously too generic. Better adding some prefix to it? > > > > I don't see any MAX_LEVEL definition in this patch. You say it is > defined in include/linux/idr.h, and as the diffstat shows, I am not > touching this file. It's a rather *unexpected* side effect. You changed slub_def.h to include memcontrol.h/cgroup.h which in turn includes idr.h. > I think this needs patching independently. Yes, sure. And perhaps send it for quick inclusion before your patches? Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined 2012-09-10 13:06 ` Fengguang Wu @ 2012-09-10 14:02 ` Glauber Costa 0 siblings, 0 replies; 4+ messages in thread From: Glauber Costa @ 2012-09-10 14:02 UTC (permalink / raw) To: Fengguang Wu; +Cc: kernel-janitors, Linux Memory Management List On 09/10/2012 05:06 PM, Fengguang Wu wrote: > On Mon, Sep 10, 2012 at 04:58:02PM +0400, Glauber Costa wrote: >> On 09/10/2012 04:57 PM, Fengguang Wu wrote: >>> Glauber, >>> >>> The patch entitled >>> >>> sl[au]b: Allocate objects from memcg cache >>> >>> changes >>> >>> include/linux/slub_def.h | 15 ++++++++++----- >>> >>> which triggers this warning: >>> >>> drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined >>> >>> It's the MAX_LEVEL that is defined in include/linux/idr.h. >>> >>> MAX_LEVEL is obviously too generic. Better adding some prefix to it? >>> >> >> I don't see any MAX_LEVEL definition in this patch. You say it is >> defined in include/linux/idr.h, and as the diffstat shows, I am not >> touching this file. > > It's a rather *unexpected* side effect. You changed slub_def.h to > include memcontrol.h/cgroup.h which in turn includes idr.h. > Indeed. >> I think this needs patching independently. > > Yes, sure. And perhaps send it for quick inclusion before your patches? > I agree. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-10 14:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120910111638.GC9660@localhost>
2012-09-10 12:57 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined Fengguang Wu
2012-09-10 12:58 ` Glauber Costa
2012-09-10 13:06 ` Fengguang Wu
2012-09-10 14:02 ` Glauber Costa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).