From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Michal Nazarewicz <mina86@mina86.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH 2/2] memory-hotplug: don't replace lowmem pages with highmem
Date: Wed, 12 Sep 2012 14:32:39 -0700 [thread overview]
Message-ID: <20120912143239.65fa8b58.akpm@linux-foundation.org> (raw)
In-Reply-To: <1347414231-31451-2-git-send-email-minchan@kernel.org>
On Wed, 12 Sep 2012 10:43:51 +0900
Minchan Kim <minchan@kernel.org> wrote:
> [1] reporeted that lowmem pages could be replaced by
> highmem pages during migration of CMA and fixed.
>
> Quote from [1]'s description
> "
> The filesystem layer expects pages in the block device's mapping to not
> be in highmem (the mapping's gfp mask is set in bdget()), but CMA can
> currently replace lowmem pages with highmem pages, leading to crashes in
> filesystem code such as the one below:
>
> Unable to handle kernel NULL pointer dereference at virtual address 00000400
> pgd = c0c98000
> [00000400] *pgd=00c91831, *pte=00000000, *ppte=00000000
> Internal error: Oops: 817 [#1] PREEMPT SMP ARM
> CPU: 0 Not tainted (3.5.0-rc5+ #80)
> PC is at __memzero+0x24/0x80
> ...
> Process fsstress (pid: 323, stack limit = 0xc0cbc2f0)
> Backtrace:
> [<c010e3f0>] (ext4_getblk+0x0/0x180) from [<c010e58c>] (ext4_bread+0x1c/0x98)
> [<c010e570>] (ext4_bread+0x0/0x98) from [<c0117944>] (ext4_mkdir+0x160/0x3bc)
> r4:c15337f0
> [<c01177e4>] (ext4_mkdir+0x0/0x3bc) from [<c00c29e0>] (vfs_mkdir+0x8c/0x98)
> [<c00c2954>] (vfs_mkdir+0x0/0x98) from [<c00c2a60>] (sys_mkdirat+0x74/0xac)
> r6:00000000 r5:c152eb40 r4:000001ff r3:c14b43f0
> [<c00c29ec>] (sys_mkdirat+0x0/0xac) from [<c00c2ab8>] (sys_mkdir+0x20/0x24)
> r6:beccdcf0 r5:00074000 r4:beccdbbc
> [<c00c2a98>] (sys_mkdir+0x0/0x24) from [<c000e3c0>] (ret_fast_syscall+0x0/0x30)
> "
>
> Memory-hotplug has same problem with CMA so [1]'s fix could be applied
> with memory-hotplug, too.
>
> Fix it by reusing.
Do we think this issue should be fixed in 3.6? Earlier?
> @@ -809,8 +802,12 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
> putback_lru_pages(&source);
> goto out;
> }
> - /* this function returns # of failed pages */
> - ret = migrate_pages(&source, hotremove_migrate_alloc, 0,
> +
> + /*
> + * alloc_migrate_target should be improooooved!!
Not a helpful comment! If you've identified some improvement then
please do provide all the details.
> + * migrate_pages returns # of failed pages.
> + */
> + ret = migrate_pages(&source, alloc_migrate_target, 0,
> true, MIGRATE_SYNC);
> if (ret)
> putback_lru_pages(&source);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-12 21:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 1:43 [PATCH 1/2] mm: refactor out __alloc_contig_migrate_alloc Minchan Kim
2012-09-12 1:43 ` [PATCH 2/2] memory-hotplug: don't replace lowmem pages with highmem Minchan Kim
2012-09-12 10:34 ` Michal Nazarewicz
2012-09-12 21:32 ` Andrew Morton [this message]
2012-09-13 0:05 ` Minchan Kim
2012-09-13 1:58 ` Yasuaki Ishimatsu
2012-09-13 2:16 ` David Rientjes
2012-09-12 10:32 ` [PATCH 1/2] mm: refactor out __alloc_contig_migrate_alloc Michal Nazarewicz
2012-09-13 1:57 ` Yasuaki Ishimatsu
2012-09-13 2:14 ` David Rientjes
2012-09-14 6:32 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912143239.65fa8b58.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).