From: Tejun Heo <tj@kernel.org>
To: Cyril Chemparathy <cyril@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, davem@davemloft.net,
eric.dumazet@gmail.com, hannes@cmpxchg.org,
shangw@linux.vnet.ibm.com, vitalya@ti.com
Subject: Re: [PATCH] mm: bootmem: use phys_addr_t for physical addresses
Date: Wed, 12 Sep 2012 13:39:20 -0700 [thread overview]
Message-ID: <20120912203920.GU7677@google.com> (raw)
In-Reply-To: <1347466008-7231-1-git-send-email-cyril@ti.com>
Hello,
On Wed, Sep 12, 2012 at 12:06:48PM -0400, Cyril Chemparathy wrote:
> static void * __init alloc_bootmem_core(unsigned long size,
> unsigned long align,
> - unsigned long goal,
> - unsigned long limit)
> + phys_addr_t goal,
> + phys_addr_t limit)
So, a function which takes phys_addr_t for goal and limit but returns
void * doesn't make much sense unless the function creates directly
addressable mapping somewhere.
The right thing to do would be converting to nobootmem (ie. memblock)
and use the memblock interface. Have no idea at all whether that
would be a realistic short-term solution for arm.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-12 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 16:06 [PATCH] mm: bootmem: use phys_addr_t for physical addresses Cyril Chemparathy
2012-09-12 20:39 ` Tejun Heo [this message]
2012-09-13 0:08 ` Cyril Chemparathy
2012-09-13 0:34 ` Tejun Heo
2012-09-13 0:40 ` Cyril Chemparathy
2012-09-13 19:32 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912203920.GU7677@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cyril@ti.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=vitalya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).