From: Andrea Arcangeli <aarcange@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Will Deacon <will.deacon@arm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 0/3] Minor changes to common hugetlb code for ARM
Date: Thu, 13 Sep 2012 02:12:55 +0200 [thread overview]
Message-ID: <20120913001255.GD3404@redhat.com> (raw)
In-Reply-To: <20120912152759.GR21579@dhcp22.suse.cz>
Hi everyone,
On Wed, Sep 12, 2012 at 05:27:59PM +0200, Michal Hocko wrote:
> On Tue 11-09-12 17:47:13, Will Deacon wrote:
> > Hello,
>
> Hi,
>
> > A few changes are required to common hugetlb code before the ARM support
> > can be merged. I posted the main one previously, which has been picked up
> > by akpm:
> >
> > http://marc.info/?l=linux-mm&m=134573987631394&w=2
> >
> > The remaining three patches (included here) are all fairly minor but do
> > affect other architectures.
>
> I am quite confused. Why THP changes are required for hugetlb code for
> ARM?
Some functions are just noops on x86 and with no arch other than x86
building the huge_memory.c file, those x86-noop parts that needed
minor interface adjustments couldn't be noticed until now.
Hopefully we got the brainer part right (i.e. the location of the x86
noop callouts), it's clearly untested.
> Besides that I would suggest adding Andrea to the CC (added now the
> whole series can be found here http://lkml.org/lkml/2012/9/11/322) list
> for all THP changes.
>
> >
> > All comments welcome,
> >
> > Will
> >
> > Catalin Marinas (2):
> > mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear()
> > mm: thp: Fix the update_mmu_cache() last argument passing in
> > mm/huge_memory.c
Both:
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
> >
> > Steve Capper (1):
> > mm: Introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE
This was already introduced by the s390 THP support which I reviewed a
few days ago, and it's already included in -mm, so it can be dropped.
Thanks!
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-09-13 0:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 16:47 [PATCH 0/3] Minor changes to common hugetlb code for ARM Will Deacon
2012-09-11 16:47 ` [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear() Will Deacon
2012-09-11 17:12 ` Kirill A. Shutemov
2012-09-12 15:30 ` Michal Hocko
2012-09-11 16:47 ` [PATCH 2/3] mm: thp: Fix the update_mmu_cache() last argument passing in mm/huge_memory.c Will Deacon
2012-09-11 17:38 ` Kirill A. Shutemov
2012-09-12 15:40 ` Michal Hocko
2012-09-12 15:51 ` Catalin Marinas
2012-09-15 13:38 ` Ralf Baechle
2012-09-18 19:33 ` Andrew Morton
2012-09-19 9:12 ` Catalin Marinas
2012-09-19 15:53 ` Ralf Baechle
2012-09-20 12:44 ` Will Deacon
2012-09-20 19:32 ` David Miller
2012-09-11 16:47 ` [PATCH 3/3] mm: Introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE Will Deacon
2012-09-11 17:41 ` Kirill A. Shutemov
2012-09-12 15:32 ` Michal Hocko
2012-09-12 18:06 ` Chris Metcalf
2012-09-12 18:10 ` Will Deacon
2012-09-13 19:05 ` Andrew Morton
2012-09-13 21:26 ` Will Deacon
2012-09-13 21:27 ` Stephen Rothwell
2012-09-13 21:40 ` Andrew Morton
2012-09-12 15:27 ` [PATCH 0/3] Minor changes to common hugetlb code for ARM Michal Hocko
2012-09-12 15:55 ` Will Deacon
2012-09-13 12:22 ` Michal Hocko
2012-09-13 0:12 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913001255.GD3404@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).