From: Andrea Arcangeli <aarcange@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/10] thp: implement refcounting for huge zero page
Date: Thu, 13 Sep 2012 23:17:05 +0200 [thread overview]
Message-ID: <20120913211705.GM3388@redhat.com> (raw)
In-Reply-To: <20120913173758.GA4181@shutemov.name>
Hi Kirill,
On Thu, Sep 13, 2012 at 08:37:58PM +0300, Kirill A. Shutemov wrote:
> On Thu, Sep 13, 2012 at 07:16:13PM +0200, Andrea Arcangeli wrote:
> > Hi Kirill,
> >
> > On Wed, Sep 12, 2012 at 01:07:53PM +0300, Kirill A. Shutemov wrote:
> > > - hpage = alloc_pages(GFP_TRANSHUGE | __GFP_ZERO, HPAGE_PMD_ORDER);
> >
> > The page is likely as large as a pageblock so it's unlikely to create
> > much fragmentation even if the __GFP_MOVABLE is set. Said that I guess
> > it would be more correct if __GFP_MOVABLE was clear, like
> > (GFP_TRANSHUGE | __GFP_ZERO) & ~__GFP_MOVABLE because this page isn't
> > really movable (it's only reclaimable).
>
> Good point. I'll update the patchset.
>
> > The xchg vs xchgcmp locking also looks good.
> >
> > Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
>
> Is it for the whole patchset? :)
It was meant for this one, but I reviewed the whole patchset and it
looks fine to me, so in this case it can apply to the whole patchset ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-13 21:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 13:13 [PATCH v2 00/10] Introduce huge zero page Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 01/10] thp: huge zero page: basic preparation Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 02/10] thp: zap_huge_pmd(): zap huge zero pmd Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 03/10] thp: copy_huge_pmd(): copy huge zero page Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 04/10] thp: do_huge_pmd_wp_page(): handle " Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 05/10] thp: change_huge_pmd(): keep huge zero page write-protected Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 06/10] thp: change split_huge_page_pmd() interface Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 07/10] thp: implement splitting pmd for huge zero page Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 08/10] thp: setup huge zero page on non-write page fault Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 09/10] thp: lazy huge zero page allocation Kirill A. Shutemov
2012-09-10 13:13 ` [PATCH v2 10/10] thp: implement refcounting for huge zero page Kirill A. Shutemov
2012-09-10 14:02 ` Eric Dumazet
2012-09-10 14:44 ` Kirill A. Shutemov
2012-09-10 14:48 ` Eric Dumazet
2012-09-10 14:50 ` Kirill A. Shutemov
2012-09-10 14:57 ` Eric Dumazet
2012-09-10 15:07 ` Kirill A. Shutemov
2012-09-12 10:07 ` [PATCH v3 " Kirill A. Shutemov
2012-09-13 17:16 ` Andrea Arcangeli
2012-09-13 17:37 ` Kirill A. Shutemov
2012-09-13 21:17 ` Andrea Arcangeli [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-02 15:19 [PATCH v3 00/10] Introduce " Kirill A. Shutemov
2012-10-02 15:19 ` [PATCH v3 10/10] thp: implement refcounting for " Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913211705.GM3388@redhat.com \
--to=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).