From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx115.postini.com [74.125.245.115]) by kanga.kvack.org (Postfix) with SMTP id 0A89A6B0199 for ; Thu, 13 Sep 2012 22:24:09 -0400 (EDT) Date: Fri, 14 Sep 2012 11:26:20 +0900 From: Minchan Kim Subject: Re: [PATCH v3 2/5] cma: fix counting of isolated pages Message-ID: <20120914022620.GG5085@bbox> References: <1346765185-30977-1-git-send-email-b.zolnierkie@samsung.com> <1346765185-30977-3-git-send-email-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346765185-30977-3-git-send-email-b.zolnierkie@samsung.com> Sender: owner-linux-mm@kvack.org List-ID: To: Bartlomiej Zolnierkiewicz Cc: linux-mm@kvack.org, m.szyprowski@samsung.com, mina86@mina86.com, mgorman@suse.de, hughd@google.com, kyungmin.park@samsung.com On Tue, Sep 04, 2012 at 03:26:22PM +0200, Bartlomiej Zolnierkiewicz wrote: > Isolated free pages shouldn't be accounted to NR_FREE_PAGES counter. > Fix it by properly decreasing/increasing NR_FREE_PAGES counter in > set_migratetype_isolate()/unset_migratetype_isolate() and removing > counter adjustment for isolated pages from free_one_page() and > split_free_page(). > > Cc: Marek Szyprowski > Cc: Michal Nazarewicz > Cc: Minchan Kim > Cc: Mel Gorman > Cc: Hugh Dickins > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- > mm/page_alloc.c | 7 +++++-- > mm/page_isolation.c | 13 ++++++++++--- > 2 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e9da55c..3acdf0f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -691,7 +691,8 @@ static void free_one_page(struct zone *zone, struct page *page, int order, > zone->pages_scanned = 0; > > __free_one_page(page, zone, order, migratetype); > - __mod_zone_page_state(zone, NR_FREE_PAGES, 1 << order); > + if (migratetype != MIGRATE_ISOLATE) We can add unlikely. > + __mod_zone_page_state(zone, NR_FREE_PAGES, 1 << order); > spin_unlock(&zone->lock); > } > > @@ -1414,7 +1415,9 @@ int split_free_page(struct page *page, bool check_wmark) > list_del(&page->lru); > zone->free_area[order].nr_free--; > rmv_page_order(page); > - __mod_zone_page_state(zone, NR_FREE_PAGES, -(1UL << order)); > + > + if (get_pageblock_migratetype(page) != MIGRATE_ISOLATE) The get_pageblock_migratetype isn't cheap. You can use get_freepage_migratetype. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org