From: Minchan Kim <minchan@kernel.org>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-mm@kvack.org, m.szyprowski@samsung.com, mina86@mina86.com,
mgorman@suse.de, hughd@google.com, kyungmin.park@samsung.com
Subject: Re: [PATCH v4 1/4] mm: fix tracing in free_pcppages_bulk()
Date: Wed, 19 Sep 2012 17:03:21 +0900 [thread overview]
Message-ID: <20120919080321.GB13234@bbox> (raw)
In-Reply-To: <50597829.9010801@jp.fujitsu.com>
On Wed, Sep 19, 2012 at 04:45:45PM +0900, Yasuaki Ishimatsu wrote:
> Hi Minchan,
>
> 2012/09/19 16:32, Minchan Kim wrote:
> >Hi Yasuaki,
> >
> >On Wed, Sep 19, 2012 at 04:07:19PM +0900, Yasuaki Ishimatsu wrote:
> >>Hi Bartlomiej,
> >>
> >>2012/09/14 23:29, Bartlomiej Zolnierkiewicz wrote:
> >>>page->private gets re-used in __free_one_page() to store page order
> >>>(so trace_mm_page_pcpu_drain() may print order instead of migratetype)
> >>>thus migratetype value must be cached locally.
> >>>
> >>>Fixes regression introduced in a701623 ("mm: fix migratetype bug
> >>>which slowed swapping").
> >>
> >>I think the regression has been alreadly fixed by following Mincahn's patches.
> >>
> >>https://lkml.org/lkml/2012/9/6/635
> >>
> >>=> Hi Minchan,
> >>
> >> Am I wrong?
> >
> >This patch isn't related to mine.
>
> According to the description, the regression occurs by clearing migratetype
> info from page->private at __free_one_page(). If we apply your patches,
> migratetype info is stored into page->index. So the migratetype info is not
> cleared. Thus we do not need to cache the info locally.
Brain-dead. I totally forgot my implementation.
You're absolutely right but it's a just side-effect of my implementation
so description of my patch doesn't say anything about this bug.
Although my patch solve this problem by chance, we should merge
this patch before mine and rebase mine onto this, I think.
Andrew?
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-19 8:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 14:29 [PATCH v4 0/4] cma: fix watermark checking Bartlomiej Zolnierkiewicz
2012-09-14 14:29 ` [PATCH v4 1/4] mm: fix tracing in free_pcppages_bulk() Bartlomiej Zolnierkiewicz
2012-09-19 7:07 ` Yasuaki Ishimatsu
2012-09-19 7:32 ` Minchan Kim
2012-09-19 7:45 ` Yasuaki Ishimatsu
2012-09-19 8:03 ` Minchan Kim [this message]
2012-09-19 18:07 ` KOSAKI Motohiro
2012-09-19 19:28 ` Andrew Morton
2012-09-14 14:29 ` [PATCH v4 2/4] cma: fix counting of isolated pages Bartlomiej Zolnierkiewicz
2012-09-14 14:29 ` [PATCH v4 3/4] cma: count free CMA pages Bartlomiej Zolnierkiewicz
2012-09-14 14:29 ` [PATCH v4 4/4] cma: fix watermark checking Bartlomiej Zolnierkiewicz
2012-09-19 19:51 ` Andrew Morton
2012-09-24 9:30 ` Bartlomiej Zolnierkiewicz
2012-09-24 21:30 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919080321.GB13234@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=hughd@google.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).