From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Nitin Gupta <ngupta@vflare.org>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured
Date: Wed, 26 Sep 2012 09:15:39 -0700 [thread overview]
Message-ID: <20120926161539.GA30132@kroah.com> (raw)
In-Reply-To: <1348649419-16494-4-git-send-email-minchan@kernel.org>
On Wed, Sep 26, 2012 at 05:50:19PM +0900, Minchan Kim wrote:
> At the monent, we can configure zram in driver/block once zsmalloc
> in /lib menu is configured firstly. It's not convenient.
>
> User can configure zram in driver/block regardless of zsmalloc enabling
> by this patch.
>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
> ---
> drivers/block/zram/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig
> index be5abe8..ee23a86 100644
> --- a/drivers/block/zram/Kconfig
> +++ b/drivers/block/zram/Kconfig
> @@ -1,6 +1,7 @@
> config ZRAM
> tristate "Compressed RAM block device support"
> - depends on BLOCK && SYSFS && ZSMALLOC
> + depends on BLOCK && SYSFS
> + select ZSMALLOC
As ZSMALLOC is dependant on CONFIG_STAGING, this isn't going to work at
all, sorry.
If your code depends on staging code, we need to get the staging code
out of staging first, before this code can be moved out.
So please work to get zsmalloc cleaned up and merged out first please,
as it is, this patch series is not ok.
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-26 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 8:50 [PATCH 0/3] zram/zsmalloc promotion Minchan Kim
2012-09-26 8:50 ` [PATCH 1/3] zsmalloc: promote to lib/ Minchan Kim
2012-09-26 9:42 ` Wanlong Gao
2012-09-26 9:51 ` Pekka Enberg
2012-09-26 17:06 ` Nitin Gupta
2012-09-27 1:39 ` Minchan Kim
2012-09-27 1:47 ` Andrew Morton
2012-09-27 1:50 ` Minchan Kim
2012-09-26 8:50 ` [PATCH 2/3] zram: promote zram from staging Minchan Kim
2012-09-26 9:54 ` Pekka Enberg
2012-09-26 8:50 ` [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured Minchan Kim
2012-09-26 16:15 ` Greg Kroah-Hartman [this message]
2012-09-26 16:23 ` Calvin Walton
2012-09-26 16:29 ` Greg Kroah-Hartman
2012-09-27 1:53 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120926161539.GA30132@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=dan.magenheimer@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).