From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx155.postini.com [74.125.245.155]) by kanga.kvack.org (Postfix) with SMTP id B99846B002B for ; Wed, 26 Sep 2012 12:15:44 -0400 (EDT) Received: by padfa10 with SMTP id fa10so667555pad.14 for ; Wed, 26 Sep 2012 09:15:44 -0700 (PDT) Date: Wed, 26 Sep 2012 09:15:39 -0700 From: Greg Kroah-Hartman Subject: Re: [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured Message-ID: <20120926161539.GA30132@kroah.com> References: <1348649419-16494-1-git-send-email-minchan@kernel.org> <1348649419-16494-4-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1348649419-16494-4-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Jens Axboe , Nitin Gupta , Konrad Rzeszutek Wilk , Seth Jennings , Dan Magenheimer , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, Sep 26, 2012 at 05:50:19PM +0900, Minchan Kim wrote: > At the monent, we can configure zram in driver/block once zsmalloc > in /lib menu is configured firstly. It's not convenient. > > User can configure zram in driver/block regardless of zsmalloc enabling > by this patch. > > Signed-off-by: Minchan Kim > --- > drivers/block/zram/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig > index be5abe8..ee23a86 100644 > --- a/drivers/block/zram/Kconfig > +++ b/drivers/block/zram/Kconfig > @@ -1,6 +1,7 @@ > config ZRAM > tristate "Compressed RAM block device support" > - depends on BLOCK && SYSFS && ZSMALLOC > + depends on BLOCK && SYSFS > + select ZSMALLOC As ZSMALLOC is dependant on CONFIG_STAGING, this isn't going to work at all, sorry. If your code depends on staging code, we need to get the staging code out of staging first, before this code can be moved out. So please work to get zsmalloc cleaned up and merged out first please, as it is, this patch series is not ok. greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org