Re: [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Sep 26, 2012 at 12:23:35PM -0400, Calvin Walton wrote:
> On Wed, 2012-09-26 at 09:15 -0700, Greg Kroah-Hartman wrote:
> > On Wed, Sep 26, 2012 at 05:50:19PM +0900, Minchan Kim wrote:
> > > At the monent, we can configure zram in driver/block once zsmalloc
> > > in /lib menu is configured firstly. It's not convenient.
> > > 
> > > User can configure zram in driver/block regardless of zsmalloc enabling
> > > by this patch.
> > > 
> > > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > > ---
> > >  drivers/block/zram/Kconfig |    3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig
> > > index be5abe8..ee23a86 100644
> > > --- a/drivers/block/zram/Kconfig
> > > +++ b/drivers/block/zram/Kconfig
> > > @@ -1,6 +1,7 @@
> > >  config ZRAM
> > >  	tristate "Compressed RAM block device support"
> > > -	depends on BLOCK && SYSFS && ZSMALLOC
> > > +	depends on BLOCK && SYSFS
> > > +	select ZSMALLOC
> > 
> > As ZSMALLOC is dependant on CONFIG_STAGING, this isn't going to work at
> > all, sorry.
> 
> Perhaps you missed [PATCH 1/3] zsmalloc: promote to lib/ ? The first
> patch in this series moves zsmalloc out of the staging directory, and
> removes the dependency on CONFIG_STAGING.

Ah, I did, thanks.

For 3.7, it's too late to be moving stuff out of staging to the "real"
part of the kernel as 3.6 is about to be released.

Possibly, if everyone agrees with this, after 3.7 is out we can do this
for 3.8, ok?

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>