From: Minchan Kim <minchan@kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] zsmalloc: promote to lib/
Date: Thu, 27 Sep 2012 10:39:12 +0900 [thread overview]
Message-ID: <20120927013912.GB10229@bbox> (raw)
In-Reply-To: <CAOJsxLGjp5PAgPe3KSvMfqJEyVC4YHeP+FW3AmnCorpHqnfang@mail.gmail.com>
Hi Pekka,
On Wed, Sep 26, 2012 at 12:51:49PM +0300, Pekka Enberg wrote:
> On Wed, Sep 26, 2012 at 11:50 AM, Minchan Kim <minchan@kernel.org> wrote:
> > lib/Kconfig | 2 +
> > lib/Makefile | 1 +
> > lib/zsmalloc/Kconfig | 18 +
> > lib/zsmalloc/Makefile | 1 +
> > lib/zsmalloc/zsmalloc.c | 1064 ++++++++++++++++++++++++++++++
>
> What's wrong with mm/zsmalloc.c?
Why I put zsmalloc into under mm firstly is that Andrew had a concern
about using strut page's some fields freely in zsmalloc so he wanted
to maintain it in mm/ if I remember correctly.
So I and Nitin tried to ask the opinion to akpm several times
(at least 5 and even I sent such patch a few month ago) but didn't get
any reply from him so I guess he doesn't have any concern about that
any more.
In point of view that it's an another slab-like allocator,
it might be proper under mm but it's not popular as current mm's
allocators(/SLUB/SLOB and page allocator).
Frankly speaking, I'm okay whether we put it to mm/ or lib/.
But it seems Nitin and Konrad like lib/ and Andrew is silent.
That's why I am biased into lib/ now.
If someone yell we should keep it to mm/ by logical claim,
I can change my mind easily.
But I've never heard abut that until now.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-27 1:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 8:50 [PATCH 0/3] zram/zsmalloc promotion Minchan Kim
2012-09-26 8:50 ` [PATCH 1/3] zsmalloc: promote to lib/ Minchan Kim
2012-09-26 9:42 ` Wanlong Gao
2012-09-26 9:51 ` Pekka Enberg
2012-09-26 17:06 ` Nitin Gupta
2012-09-27 1:39 ` Minchan Kim [this message]
2012-09-27 1:47 ` Andrew Morton
2012-09-27 1:50 ` Minchan Kim
2012-09-26 8:50 ` [PATCH 2/3] zram: promote zram from staging Minchan Kim
2012-09-26 9:54 ` Pekka Enberg
2012-09-26 8:50 ` [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured Minchan Kim
2012-09-26 16:15 ` Greg Kroah-Hartman
2012-09-26 16:23 ` Calvin Walton
2012-09-26 16:29 ` Greg Kroah-Hartman
2012-09-27 1:53 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927013912.GB10229@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=penberg@kernel.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).