From: Minchan Kim <minchan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Calvin Walton <calvin.walton@kepstin.ca>,
Jens Axboe <axboe@kernel.dk>, Nitin Gupta <ngupta@vflare.org>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured
Date: Thu, 27 Sep 2012 10:53:59 +0900 [thread overview]
Message-ID: <20120927015359.GD10229@bbox> (raw)
In-Reply-To: <20120926162941.GA29694@kroah.com>
On Wed, Sep 26, 2012 at 09:29:41AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Sep 26, 2012 at 12:23:35PM -0400, Calvin Walton wrote:
> > On Wed, 2012-09-26 at 09:15 -0700, Greg Kroah-Hartman wrote:
> > > On Wed, Sep 26, 2012 at 05:50:19PM +0900, Minchan Kim wrote:
> > > > At the monent, we can configure zram in driver/block once zsmalloc
> > > > in /lib menu is configured firstly. It's not convenient.
> > > >
> > > > User can configure zram in driver/block regardless of zsmalloc enabling
> > > > by this patch.
> > > >
> > > > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > > > ---
> > > > drivers/block/zram/Kconfig | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig
> > > > index be5abe8..ee23a86 100644
> > > > --- a/drivers/block/zram/Kconfig
> > > > +++ b/drivers/block/zram/Kconfig
> > > > @@ -1,6 +1,7 @@
> > > > config ZRAM
> > > > tristate "Compressed RAM block device support"
> > > > - depends on BLOCK && SYSFS && ZSMALLOC
> > > > + depends on BLOCK && SYSFS
> > > > + select ZSMALLOC
> > >
> > > As ZSMALLOC is dependant on CONFIG_STAGING, this isn't going to work at
> > > all, sorry.
> >
> > Perhaps you missed [PATCH 1/3] zsmalloc: promote to lib/ ? The first
> > patch in this series moves zsmalloc out of the staging directory, and
> > removes the dependency on CONFIG_STAGING.
>
> Ah, I did, thanks.
>
> For 3.7, it's too late to be moving stuff out of staging to the "real"
> part of the kernel as 3.6 is about to be released.
>
> Possibly, if everyone agrees with this, after 3.7 is out we can do this
> for 3.8, ok?
For me, no problem.
I will send the patchset after listening akpm's opinion about zsmalloc's
location. Maybe nextweek.
Thanks, Greg.
>
> thanks,
>
> greg k-h
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-09-27 1:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 8:50 [PATCH 0/3] zram/zsmalloc promotion Minchan Kim
2012-09-26 8:50 ` [PATCH 1/3] zsmalloc: promote to lib/ Minchan Kim
2012-09-26 9:42 ` Wanlong Gao
2012-09-26 9:51 ` Pekka Enberg
2012-09-26 17:06 ` Nitin Gupta
2012-09-27 1:39 ` Minchan Kim
2012-09-27 1:47 ` Andrew Morton
2012-09-27 1:50 ` Minchan Kim
2012-09-26 8:50 ` [PATCH 2/3] zram: promote zram from staging Minchan Kim
2012-09-26 9:54 ` Pekka Enberg
2012-09-26 8:50 ` [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured Minchan Kim
2012-09-26 16:15 ` Greg Kroah-Hartman
2012-09-26 16:23 ` Calvin Walton
2012-09-26 16:29 ` Greg Kroah-Hartman
2012-09-27 1:53 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927015359.GD10229@bbox \
--to=minchan@kernel.org \
--cc=axboe@kernel.dk \
--cc=calvin.walton@kepstin.ca \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).