From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx173.postini.com [74.125.245.173]) by kanga.kvack.org (Postfix) with SMTP id 701CB6B0069 for ; Fri, 28 Sep 2012 07:54:11 -0400 (EDT) Date: Fri, 28 Sep 2012 19:54:05 +0800 From: Fengguang Wu Subject: Re: Re: [PATCH 1/5] mm/readahead: Check return value of read_pages Message-ID: <20120928115405.GA1525@localhost> References: <20120922124337.GA17562@localhost> <20120926012503.GA24218@Archie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120926012503.GA24218@Archie> Sender: owner-linux-mm@kvack.org List-ID: To: Raghavendra D Prabhu Cc: linux-mm@kvack.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org On Wed, Sep 26, 2012 at 06:55:03AM +0530, Raghavendra D Prabhu wrote: > > Hi, > > > * On Sat, Sep 22, 2012 at 08:43:37PM +0800, Fengguang Wu wrote: > >On Sat, Sep 22, 2012 at 04:03:10PM +0530, raghu.prabhu13@gmail.com wrote: > >>From: Raghavendra D Prabhu > >> > >>Return value of a_ops->readpage will be propagated to return value of read_pages > >>and __do_page_cache_readahead. > > > >That does not explain the intention and benefit of this patch.. > > I noticed that force_page_cache_readahead checks return value of > __do_page_cache_readahead but the actual error if any is never > propagated. force_page_cache_readahead()'s return value, in turn, is never used by its callers.. Nor does the other __do_page_cache_readahead() callers care about the error state. So until we find an actual user of the error code, I'd recommend to avoid changing the current code. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org