From: Andrea Arcangeli <aarcange@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: Re: [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock
Date: Fri, 28 Sep 2012 15:30:06 +0200 [thread overview]
Message-ID: <20120928133005.GA19474@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209191818490.7879@chino.kir.corp.google.com>
Hi David,
On Wed, Sep 19, 2012 at 06:19:27PM -0700, David Rientjes wrote:
> + if ((flags & FOLL_MLOCK) && (vma->vm_flags & VM_LOCKED)) {
> + if (page->mapping && trylock_page(page)) {
> + lru_add_drain();
> + if (page->mapping)
> + mlock_vma_page(page);
> + unlock_page(page);
> + }
> + }
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
Without the patch the kernel will be perfectly fine too, this is is
only to show more "uptodate" values in meminfo.
The meminfo would eventually go in sync as the vmscan started walking
lrus and the old behavior will still happen when trylock
fails.
Without the patch the refiling events happen lazily as needed, now
they happen even if they're not needed.
In some ways we could drop this and also the 4k case and we'd overall
improve performance.
But transparent hugepages must behave identical to 4k pages, so unless
we remove it from the 4k case, it's certainly good to apply the above.
The patch can be deferred to 3.7 if needed.
Thanks!
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-09-28 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 1:19 [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock David Rientjes
2012-09-20 4:01 ` Hugh Dickins
2012-09-27 1:40 ` David Rientjes
2012-09-27 1:54 ` Hugh Dickins
2012-09-27 2:29 ` [patch] mm, thp: fix mlock statistics David Rientjes
2012-09-28 1:32 ` Hugh Dickins
2012-10-03 20:10 ` Andrew Morton
2012-10-03 21:10 ` [patch -mm] mm, thp: fix mlock statistics fix David Rientjes
2012-10-03 21:25 ` Andrew Morton
2012-10-03 21:46 ` Hugh Dickins
2012-10-03 21:29 ` Hugh Dickins
2012-09-28 13:51 ` [patch] mm, thp: fix mlock statistics Andrea Arcangeli
2012-09-29 0:11 ` Michel Lespinasse
2012-10-01 15:22 ` [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock Linus Torvalds
2012-09-28 13:30 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928133005.GA19474@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).