From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, akpm@linux-foundation.org,
mhocko@suse.cz, Steve Capper <steve.capper@arm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH] mm: thp: Set the accessed flag for old pages on access fault.
Date: Mon, 1 Oct 2012 17:03:05 +0300 [thread overview]
Message-ID: <20121001140305.GA20173@shutemov.name> (raw)
In-Reply-To: <1349099505-5581-1-git-send-email-will.deacon@arm.com>
On Mon, Oct 01, 2012 at 02:51:45PM +0100, Will Deacon wrote:
> diff --git a/mm/memory.c b/mm/memory.c
> index 5736170..d5c007d 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3537,7 +3537,11 @@ retry:
> if (unlikely(ret & VM_FAULT_OOM))
> goto retry;
> return ret;
> + } else {
> + huge_pmd_set_accessed(mm, vma, address, pmd,
> + orig_pmd);
I think putting it to 'else' is wrong. You should not touch pmd, if it's
under splitting.
> }
> +
> return 0;
> }
> }
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-01 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 13:51 [PATCH] mm: thp: Set the accessed flag for old pages on access fault Will Deacon
2012-10-01 14:03 ` Kirill A. Shutemov [this message]
2012-10-01 14:59 ` Andrea Arcangeli
2012-10-01 16:32 ` Will Deacon
2012-10-16 9:37 ` Ni zhan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001140305.GA20173@shutemov.name \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).