linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: David Miller <davem@davemloft.net>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"mhocko@suse.cz" <mhocko@suse.cz>,
	"kirill@shutemov.name" <kirill@shutemov.name>,
	"aarcange@redhat.com" <aarcange@redhat.com>,
	"cmetcalf@tilera.com" <cmetcalf@tilera.com>,
	Steve Capper <Steve.Capper@arm.com>
Subject: Re: [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault.
Date: Wed, 17 Oct 2012 16:54:02 +0100	[thread overview]
Message-ID: <20121017155401.GJ5973@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20121017.112620.1865348978594874782.davem@davemloft.net>

On Wed, Oct 17, 2012 at 04:26:20PM +0100, David Miller wrote:
> From: Will Deacon <will.deacon@arm.com>
> Date: Wed, 17 Oct 2012 14:01:25 +0100
> 
> > +		update_mmu_cache(vma, address, pmd);
> 
> This won't build, use update_mmu_cache_pmd().

Good catch. They're both empty macros on ARM, so the typechecker didn't spot
it. Updated patch below.

Cheers,

Will

--->8

  reply	other threads:[~2012-10-17 15:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02 16:59 [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault Will Deacon
2012-10-02 17:46 ` Andrea Arcangeli
2012-10-02 22:01 ` Andrew Morton
2012-10-03  9:09   ` Will Deacon
2012-10-17 13:01   ` Will Deacon
2012-10-17 15:26     ` David Miller
2012-10-17 15:54       ` Will Deacon [this message]
2012-10-18 22:05         ` Andrew Morton
2012-10-19  9:10           ` Will Deacon
2012-10-19 18:49             ` Andrew Morton
2012-10-22 10:35               ` Will Deacon
2012-10-22 18:18                 ` Andrew Morton
2012-10-23 10:11                   ` Will Deacon
2012-10-23 21:50                     ` Andrew Morton
2012-10-24  9:35                       ` Will Deacon
2012-10-04 22:13 ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121017155401.GJ5973@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=Steve.Capper@arm.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cmetcalf@tilera.com \
    --cc=davem@davemloft.net \
    --cc=kirill@shutemov.name \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).