From: Will Deacon <will.deacon@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"mhocko@suse.cz" <mhocko@suse.cz>,
"kirill@shutemov.name" <kirill@shutemov.name>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"cmetcalf@tilera.com" <cmetcalf@tilera.com>,
Steve Capper <Steve.Capper@arm.com>
Subject: Re: [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault.
Date: Mon, 22 Oct 2012 11:35:03 +0100 [thread overview]
Message-ID: <20121022103503.GA26619@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20121019114955.3a0c2b66.akpm@linux-foundation.org>
On Fri, Oct 19, 2012 at 07:49:55PM +0100, Andrew Morton wrote:
> On Fri, 19 Oct 2012 10:10:16 +0100
> Will Deacon <will.deacon@arm.com> wrote:
>
> > On Thu, Oct 18, 2012 at 11:05:02PM +0100, Andrew Morton wrote:
> > > On Wed, 17 Oct 2012 16:54:02 +0100
> > > Will Deacon <will.deacon@arm.com> wrote:
> > >
> > > > On x86 memory accesses to pages without the ACCESSED flag set result in the
> > > > ACCESSED flag being set automatically. With the ARM architecture a page access
> > > > fault is raised instead (and it will continue to be raised until the ACCESSED
> > > > flag is set for the appropriate PTE/PMD).
> > > >
> > > > For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
> > > > setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
> > > > be called for a write fault.
> > > >
> > > > This patch ensures that faults on transparent hugepages which do not result
> > > > in a CoW update the access flags for the faulting pmd.
> > >
> > > Confused. Where is the arm implementation of update_mmu_cache_pmd()?
> >
> > Right at the end of this patch, which was posted to the ARM list yesterday:
> >
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-October/126387.html
>
> I received and then merged a patch which won't compile!
Eek, that certainly wasn't intentional and it's compiling fine for me on
-rc1 and -rc2 for both ARM (no THP) and x86 (with and without THP).
Please can you send the build failure?
> Ho hum. I'll drop
> mm-thp-set-the-accessed-flag-for-old-pages-on-access-fault.patch and
> shall assume that you'll sort things out at the appropriate time.
Happy to sort it out once I work out what's going wrong!
Cheers,
Will
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-22 10:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 16:59 [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault Will Deacon
2012-10-02 17:46 ` Andrea Arcangeli
2012-10-02 22:01 ` Andrew Morton
2012-10-03 9:09 ` Will Deacon
2012-10-17 13:01 ` Will Deacon
2012-10-17 15:26 ` David Miller
2012-10-17 15:54 ` Will Deacon
2012-10-18 22:05 ` Andrew Morton
2012-10-19 9:10 ` Will Deacon
2012-10-19 18:49 ` Andrew Morton
2012-10-22 10:35 ` Will Deacon [this message]
2012-10-22 18:18 ` Andrew Morton
2012-10-23 10:11 ` Will Deacon
2012-10-23 21:50 ` Andrew Morton
2012-10-24 9:35 ` Will Deacon
2012-10-04 22:13 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022103503.GA26619@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Steve.Capper@arm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=kirill@shutemov.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).