From: Andrew Morton <akpm@linux-foundation.org>
To: Will Deacon <will.deacon@arm.com>
Cc: David Miller <davem@davemloft.net>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"mhocko@suse.cz" <mhocko@suse.cz>,
"kirill@shutemov.name" <kirill@shutemov.name>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"cmetcalf@tilera.com" <cmetcalf@tilera.com>,
Steve Capper <Steve.Capper@arm.com>
Subject: Re: [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault.
Date: Tue, 23 Oct 2012 14:50:27 -0700 [thread overview]
Message-ID: <20121023145027.40710e7a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121023101125.GA20210@mudshark.cambridge.arm.com>
On Tue, 23 Oct 2012 11:11:25 +0100
Will Deacon <will.deacon@arm.com> wrote:
> On Mon, Oct 22, 2012 at 07:18:43PM +0100, Andrew Morton wrote:
> > On Mon, 22 Oct 2012 11:35:03 +0100
> > Will Deacon <will.deacon@arm.com> wrote:
> >
> > > On Fri, Oct 19, 2012 at 07:49:55PM +0100, Andrew Morton wrote:
> > > > Ho hum. I'll drop
> > > > mm-thp-set-the-accessed-flag-for-old-pages-on-access-fault.patch and
> > > > shall assume that you'll sort things out at the appropriate time.
> > >
> > > Happy to sort it out once I work out what's going wrong!
> >
> > The patch "ARM: mm: Transparent huge page support for LPAE systems" is
> > not present in linux-next, so this patch ("mm: thp: Set the accessed
> > flag for old pages on access fault") will not compile?
>
> This patch ("mm: thp: Set the accessed flag for old pages on access fault")
> doesn't depend on "ARM: mm: Transparent huge page support for LPAE systems"
> because currently transparent huge pages cannot be enabled for ARM in
> mainline (or linux-next). update_mmu_cache_pmd is only called from
> mm/huge_memory.c, which depends on CONFIG_TRANSPARENT_HUGEPAGE=y.
>
> As for the new huge_pmd_set_accessed function... there's a similar situation
> for the do_huge_pmd_wp_page function: it's called from mm/memory.c but is
> only defined in mm/huge_memory.c. Looks like the compiler optimises those
> calls away because pmd_trans_huge and friends constant-fold to 0.
Ah, OK.
"mm: thp: Set the accessed flag for old pages on access fault" clashes
in a non-trivial way with linux-next changes, due to the sched-numa
changes (sigh). This is a problem for me, because I either need to
significantly alter your patch (so it isn't applicable to mainline) or
I need to stage your patch ahead of linux-next, then fix up linux-next
every day after I've pulled and re-merged it.
I'm unsure what your timing is. Can you carry "mm: thp: Set the
accessed flag for old pages on access fault" until either the whole
patchset is ready to merge or until the sched-numa situation has been
cleared up?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-23 21:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 16:59 [PATCH v2] mm: thp: Set the accessed flag for old pages on access fault Will Deacon
2012-10-02 17:46 ` Andrea Arcangeli
2012-10-02 22:01 ` Andrew Morton
2012-10-03 9:09 ` Will Deacon
2012-10-17 13:01 ` Will Deacon
2012-10-17 15:26 ` David Miller
2012-10-17 15:54 ` Will Deacon
2012-10-18 22:05 ` Andrew Morton
2012-10-19 9:10 ` Will Deacon
2012-10-19 18:49 ` Andrew Morton
2012-10-22 10:35 ` Will Deacon
2012-10-22 18:18 ` Andrew Morton
2012-10-23 10:11 ` Will Deacon
2012-10-23 21:50 ` Andrew Morton [this message]
2012-10-24 9:35 ` Will Deacon
2012-10-04 22:13 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023145027.40710e7a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Steve.Capper@arm.com \
--cc=aarcange@redhat.com \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=kirill@shutemov.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).