* [PATCH v2] Change the check for PageReadahead into an else-if
@ 2012-10-24 21:26 raghu.prabhu13
2012-10-24 23:49 ` Fengguang Wu
0 siblings, 1 reply; 2+ messages in thread
From: raghu.prabhu13 @ 2012-10-24 21:26 UTC (permalink / raw)
To: kosaki.motohiro, fengguang.wu, zheng.z.yan
Cc: linux-mm, linux-btrfs, Raghavendra D Prabhu
From: Raghavendra D Prabhu <rprabhu@wnohang.net>
>From 51daa88ebd8e0d437289f589af29d4b39379ea76, page_sync_readahead coalesces
async readahead into its readahead window, so another checking for that again is
not required.
Version 2: Fixed the incorrect indentation.
Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>
---
fs/btrfs/relocation.c | 4 +---
mm/filemap.c | 3 +--
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 776f0aa..8cfa1ab 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -2996,9 +2996,7 @@ static int relocate_file_extent_cluster(struct inode *inode,
ret = -ENOMEM;
goto out;
}
- }
-
- if (PageReadahead(page)) {
+ } else if (PageReadahead(page)) {
page_cache_async_readahead(inode->i_mapping,
ra, NULL, page, index,
last_index + 1 - index);
diff --git a/mm/filemap.c b/mm/filemap.c
index 83efee7..aa440f16 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1113,8 +1113,7 @@ find_page:
page = find_get_page(mapping, index);
if (unlikely(page == NULL))
goto no_cached_page;
- }
- if (PageReadahead(page)) {
+ } else if (PageReadahead(page)) {
page_cache_async_readahead(mapping,
ra, filp, page,
index, last_index - index);
--
1.8.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] Change the check for PageReadahead into an else-if
2012-10-24 21:26 [PATCH v2] Change the check for PageReadahead into an else-if raghu.prabhu13
@ 2012-10-24 23:49 ` Fengguang Wu
0 siblings, 0 replies; 2+ messages in thread
From: Fengguang Wu @ 2012-10-24 23:49 UTC (permalink / raw)
To: raghu.prabhu13, Andrew Morton
Cc: kosaki.motohiro, zheng.z.yan, linux-mm, linux-btrfs,
Raghavendra D Prabhu
On Thu, Oct 25, 2012 at 02:56:04AM +0530, raghu.prabhu13@gmail.com wrote:
> From: Raghavendra D Prabhu <rprabhu@wnohang.net>
>
> >From 51daa88ebd8e0d437289f589af29d4b39379ea76, page_sync_readahead coalesces
> async readahead into its readahead window, so another checking for that again is
> not required.
>
> Version 2: Fixed the incorrect indentation.
>
> Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>
> ---
> fs/btrfs/relocation.c | 4 +---
> mm/filemap.c | 3 +--
> 2 files changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-24 23:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 21:26 [PATCH v2] Change the check for PageReadahead into an else-if raghu.prabhu13
2012-10-24 23:49 ` Fengguang Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).