From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx185.postini.com [74.125.245.185]) by kanga.kvack.org (Postfix) with SMTP id F0E756B0072 for ; Fri, 26 Oct 2012 10:44:03 -0400 (EDT) Date: Fri, 26 Oct 2012 17:34:54 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 1/2] numa, mm: drop redundant check in do_huge_pmd_numa_page() Message-ID: <20121026143454.GA10898@otc-wbsnb-06> References: <1351256077-1594-1-git-send-email-kirill.shutemov@linux.intel.com> <1351256885.16863.62.camel@twins> <20121026134129.GA31306@otc-wbsnb-06> <1351258992.16863.77.camel@twins> <20121026135750.GA16598@otc-wbsnb-06> <1351260464.16863.80.camel@twins> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <1351260464.16863.80.camel@twins> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: linux-mm@kvack.org, Will Deacon , Andrew Morton , Andrea Arcangeli , Xiao Guangrong , Ingo Molnar , linux-kernel@vger.kernel.org --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 26, 2012 at 04:07:44PM +0200, Peter Zijlstra wrote: > On Fri, 2012-10-26 at 16:57 +0300, Kirill A. Shutemov wrote: > > > > Yes, this code will catch it: > > > >=20 > > > > /* if an huge pmd materialized from under us just retry later */ > > > > if (unlikely(pmd_trans_huge(*pmd))) > > > > return 0; > > > >=20 > > > > If the pmd is under splitting it's still a pmd_trans_huge(). > > >=20 > > > OK, so then we simply keep taking the same fault until the split is > > > complete? Wouldn't it be better to wait for it instead of spin on > > > faults? > >=20 > > IIUC, on next fault we will wait split the page in fallow_page().=20 >=20 > What follow_page()?, a regular hardware page-fault will not call > follow_page() afaict, we do a down_read(), find_vma() and call > handle_mm_fault() -- with a lot of error and corner case checking in > between. Yeah, you're right. Then, it seems we're spinning on the fault until the page is splitted. I'm not sure how long spliting takes and if splitting itself can fix some fault reason. --=20 Kirill A. Shutemov --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQip+OAAoJEAd+omnVudOMppYP/RlkBQIfIz8WnB67L+ZpdScQ ki2oWRraf3VkmcSfomfvL6Gyv5iraWWqbsDIARBA+v5iXjiKuzQArLzVkQPYnVMK C3kh4b6jTrueAK+lcnT8c/bvd/VnGj5AHcm0QNx1VEByCjeZYEHhKCzVHzbDBQZn pzDPXaNtD1Y7tIGd/8HtM+Znq5ifogLzlJecef1eGNxGs/0apay2npFhW6UzYEPG u/Y4LjoaecBPc3ydh/UGlTWXaiD241a00TZfovFj/CywUAcRrD0EQSyfW2/t134v dGCbK9tqXPa3P/NCa5WquS4Ayod9iS89cn7QZdF+hDIHz3Bxih5mQDP0yED0mFE2 aOVp/ZOu+cK9sCu3VDFL8N+dSBp6yBryNFjoji2cdbIrFu9twMNZL/BLSykytXvm SPiYj3JAkRipVb7hiSnyvbLhW1plVKqm3G5P+zuGDokHG8fEaTtu1HUQrUgQ8d58 bu5zDgBm2/0LuKhkdR1g3aHqHo/OlH3Oru48NpzMQmjKxRfMGOoNu+6qvGaSyvY4 qXknj36Ss4R7SQgTQdZRslNcAqvE5n48Jk9zHRQEvgafEfEDc+LooA95xVka9jDF 4YjaARQkFV5AIEfBnVQKt7TnyasaKm5ruwyGHMukCGgq7ez6Cln7cyFbW6JKhy/g LlyIM5I1n6HR40aNSJr3 =5aLN -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org