From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: torvalds@linux-foundation.org, tj@kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, paul.gortmaker@windriver.com,
davem@davemloft.net, rostedt@goodmis.org, mingo@elte.hu,
ebiederm@xmission.com, aarcange@redhat.com, ericvh@gmail.com,
netdev@vger.kernel.org, josh@joshtriplett.org,
eric.dumazet@gmail.com, axboe@kernel.dk, agk@redhat.com,
dm-devel@redhat.com, neilb@suse.de, ccaulfie@redhat.com,
teigland@redhat.com, Trond.Myklebust@netapp.com,
bfields@fieldses.org, fweisbec@gmail.com, jesse@nicira.com,
venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
snitzer@redhat.com, edumazet@google.com,
linux-nfs@vger.kernel.org, dev@openvswitch.org,
rds-devel@oss.oracle.com, lw@cn.fujitsu.com
Subject: Re: [PATCH v7 08/16] block,elevator: use new hashtable implementation
Date: Mon, 29 Oct 2012 08:20:52 -0400 [thread overview]
Message-ID: <20121029122052.GB11733@Krystal> (raw)
In-Reply-To: <1351450948-15618-8-git-send-email-levinsasha928@gmail.com>
* Sasha Levin (levinsasha928@gmail.com) wrote:
[...]
> @@ -96,6 +97,8 @@ struct elevator_type
> struct list_head list;
> };
>
> +#define ELV_HASH_BITS 6
> +
> /*
> * each queue has an elevator_queue associated with it
> */
> @@ -105,7 +108,7 @@ struct elevator_queue
> void *elevator_data;
> struct kobject kobj;
> struct mutex sysfs_lock;
> - struct hlist_head *hash;
> + DECLARE_HASHTABLE(hash, ELV_HASH_BITS);
> unsigned int registered:1;
Hrm, so this is moving "registered" out of the elevator_queue first
cache-line by turning the pointer into a 256 or 512 bytes hash table.
Maybe we should consider moving "registered" before the "hash" field ?
Thanks,
Mathieu
> };
>
> --
> 1.7.12.4
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-29 12:20 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 19:02 [PATCH v7 01/16] hashtable: introduce a small and naive hashtable Sasha Levin
2012-10-28 19:02 ` [PATCH v7 02/16] userns: use new hashtable implementation Sasha Levin
2012-10-28 19:02 ` [PATCH v7 03/16] mm,ksm: " Sasha Levin
2012-10-28 19:02 ` [PATCH v7 04/16] workqueue: " Sasha Levin
2012-10-29 1:25 ` Tejun Heo
2012-10-28 19:02 ` [PATCH v7 05/16] mm/huge_memory: " Sasha Levin
2012-10-28 19:02 ` [PATCH v7 06/16] tracepoint: " Sasha Levin
2012-10-29 11:35 ` Mathieu Desnoyers
2012-10-29 17:29 ` Sasha Levin
2012-10-29 17:50 ` Mathieu Desnoyers
2012-10-29 18:31 ` Josh Triplett
2012-10-29 18:42 ` Sasha Levin
2012-10-29 18:53 ` Mathieu Desnoyers
2012-10-29 18:58 ` Tejun Heo
2012-10-29 19:01 ` Tejun Heo
2012-10-29 19:10 ` Mathieu Desnoyers
2012-10-29 19:09 ` Sasha Levin
2012-10-29 19:12 ` Tejun Heo
2012-10-29 19:17 ` Sasha Levin
2012-10-29 19:16 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 07/16] net,9p: " Sasha Levin
2012-10-29 12:15 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 08/16] block,elevator: " Sasha Levin
2012-10-29 1:29 ` Tejun Heo
2012-10-29 12:20 ` Mathieu Desnoyers [this message]
2012-10-28 19:02 ` [PATCH v7 09/16] SUNRPC/cache: " Sasha Levin
2012-10-29 12:42 ` Mathieu Desnoyers
2012-10-29 14:49 ` Linus Torvalds
2012-10-29 15:13 ` Mathieu Desnoyers
2012-10-29 15:16 ` J. Bruce Fields
2012-10-29 15:41 ` Mathieu Desnoyers
2012-10-29 16:27 ` Andrew Morton
2012-10-28 19:02 ` [PATCH v7 10/16] dlm: " Sasha Levin
2012-10-29 12:46 ` Mathieu Desnoyers
2012-10-29 13:07 ` Mathieu Desnoyers
2012-10-29 15:53 ` Sasha Levin
2012-10-29 16:07 ` Mathieu Desnoyers
2012-10-29 16:23 ` David Teigland
2012-10-28 19:02 ` [PATCH v7 11/16] net,l2tp: " Sasha Levin
2012-10-29 13:04 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 12/16] dm: " Sasha Levin
2012-10-28 19:02 ` [PATCH v7 13/16] lockd: " Sasha Levin
2012-10-29 13:23 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 14/16] net,rds: " Sasha Levin
2012-10-29 13:25 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 15/16] openvswitch: " Sasha Levin
2012-10-29 13:29 ` Mathieu Desnoyers
2012-10-29 15:43 ` Sasha Levin
2012-10-29 15:59 ` Mathieu Desnoyers
2012-10-29 17:35 ` Sasha Levin
2012-10-29 18:16 ` Mathieu Desnoyers
2012-10-29 18:22 ` Tejun Heo
2012-10-29 18:35 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 16/16] tracing output: " Sasha Levin
2012-10-29 11:29 ` [PATCH v7 01/16] hashtable: introduce a small and naive hashtable Mathieu Desnoyers
2012-10-29 16:06 ` Sasha Levin
2012-10-29 16:14 ` Mathieu Desnoyers
2012-10-29 16:18 ` Tejun Heo
2012-10-29 16:22 ` Mathieu Desnoyers
2012-10-29 16:26 ` Sasha Levin
2012-10-29 16:29 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029122052.GB11733@Krystal \
--to=mathieu.desnoyers@efficios.com \
--cc=Trond.Myklebust@netapp.com \
--cc=aarcange@redhat.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=ccaulfie@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dm-devel@redhat.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=ejt@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=ericvh@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jesse@nicira.com \
--cc=josh@joshtriplett.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lw@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rds-devel@oss.oracle.com \
--cc=rostedt@goodmis.org \
--cc=snitzer@redhat.com \
--cc=teigland@redhat.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).